Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused test method #5103

Closed
wants to merge 1 commit into from

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Feb 7, 2024

As far as I can tell, this method is not used

As a bonus, we stop using the deprecated X509Certificate class

@yeikel yeikel force-pushed the remove/unused branch 2 times, most recently from 84bd0af to d121283 Compare February 7, 2024 02:30
@vietj
Copy link
Member

vietj commented May 21, 2024

this might be used in other project depending on vertx core so a check on those project should be done

@yeikel
Copy link
Contributor Author

yeikel commented May 21, 2024

this might be used in other project depending on vertx core so a check on those project should be done

What other projects are you referring to? Where should I check?

@vietj
Copy link
Member

vietj commented May 22, 2024

other projects in vert-x3 or eclipse-vertx, some of them rely on vertx-core test artifact

@yeikel
Copy link
Contributor Author

yeikel commented May 22, 2024

other projects in vert-x3 or eclipse-vertx, some of them rely on vertx-core test artifact

I am a bit confused here because this is coming from a test class and test classes are typically not published for others to use

I searched for this method name, and all the usages are from within this same project (and the method with the other signature)

@vietj
Copy link
Member

vietj commented May 23, 2024

that might be confusing but you can look at vertx-web and how it uses vertx-core VertxTest for instance

@yeikel yeikel closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants