Fix github workflows #1344
Fix github workflows #1344
Conversation
zulus
force-pushed
the
workflows
branch
2 times, most recently
from
6f8babf to
3d62103
Compare
| @@ -24,6 +24,6 @@ jobs: | |||
| maven-version: 3.9.2 | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: '16' | |||
| node-version: '18' | |||
There was a problem hiding this comment.
Make sure we use same version as in embedder
| @@ -9,6 +9,7 @@ | |||
| "yaml-language-server": "1.14.0", | |||
| "vscode-languageserver-protocol": "3.17.4-next.3", | |||
| "vscode-languageserver-types": "3.17.4-next.2", | |||
| "vscode-languageserver": "9.0.0", | |||
| "vscode-css-languageserver": "file:target/vscode-css-languageserver-1.0.0.tgz", | |||
There was a problem hiding this comment.
After this vscode-languageserver is in root so nested node_modules is not required
There was a problem hiding this comment.
I downgraded to 8.2 (9.0 have just 5 days)
| @@ -204,6 +204,8 @@ | |||
| <arg>--only=prod</arg> | |||
| <arg>--no-bin-links</arg> | |||
| <arg>--ignore-scripts</arg> | |||
| <arg>--install-strategy=hoisted</arg> | |||
| <arg>--force</arg> | |||
There was a problem hiding this comment.
Make sure dependencies are always fresh, without this tests fail on github but pass jenkins
There was a problem hiding this comment.
Force also will ignore platform requirements, so will be possible to add fsevents for mac users ;)
|
For now all tests pass, but I'm afraid sooner or later multiple "package.json" will be required to avoid too long resource paths |
mickaelistria
merged commit 1f18883
into
eclipse-wildwebdeveloper:master
|
Thank you! |
|
Long resource path will highly likely appear until vscode updates its language servers support, see: |
|
I hope. For now yaml and angular embed and use vscode-languageserver 7.0.0 (protocol 3.16.0), vue rely on vscode-languageserver 8.1.0 |
Test PR, I'm trying to stabilize tests