Skip to content

Commit

Permalink
don't configure maven-compiler in our maven plugins
Browse files Browse the repository at this point in the history 
Or the toolchain mechanism will make the compilation fail.

Moreover, I don't think we need to use tycho-compiler-jdt for compiling
our maven plugins
  • Loading branch information
@LorenzoBettini
LorenzoBettini committed Apr 19, 2023
1 parent 91cc5e9 commit 8e378fb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 28 deletions.
14 changes: 0 additions & 14 deletions org.eclipse.xtend.maven.parent/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,6 @@
</bannedPlugins>
</configuration>
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<compilerId>jdt</compilerId>
<optimize>true</optimize>
</configuration>
<dependencies>
<dependency>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-compiler-jdt</artifactId>
<version>${tycho-version}</version>
</dependency>
</dependencies>
</plugin>

This comment has been minimized.

Sign in to view

Copy link
@LorenzoBettini

LorenzoBettini Apr 19, 2023

Author Contributor

@szarnekow to make the toolchain mechanism work, I had to remove this configuration for compilation of xtext and xtend maven plugin; do you know why they were used? I seem to understand that they're not essential at all.

This comment has been minimized.

Sign in to view

Copy link
@szarnekow

szarnekow Apr 19, 2023

Contributor

I don't know for sure.
Guesses:

  • Attempt to ensure that we compile with ECJ instead of JavaC
  • Something from the Pre-Tycho 2.0 era
  • Added based on trial-and-error

If we still use ECJ, I think less config in the pom is better. 👍

This comment has been minimized.

Sign in to view

Copy link
@LorenzoBettini

LorenzoBettini Apr 19, 2023

Author Contributor

@szarnekow Thanks!
Then we can stay without that.
Of course, tests are still green.
<plugin>
<artifactId>maven-source-plugin</artifactId>
<executions>
Expand Down
14 changes: 0 additions & 14 deletions org.eclipse.xtext.maven.parent/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,6 @@
</bannedPlugins>
</configuration>
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<compilerId>jdt</compilerId>
<optimize>true</optimize>
</configuration>
<dependencies>
<dependency>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-compiler-jdt</artifactId>
<version>${tycho-version}</version>
</dependency>
</dependencies>
</plugin>
<plugin>
<artifactId>maven-source-plugin</artifactId>
<executions>
Expand Down

0 comments on commit 8e378fb

Please sign in to comment.