[Build] Extend GH workflow matrix for jdkVersion and targetPlatform #2618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the GH workflow matrix for Xtext with an axis for the
jdkVersion
andtargetPlatform
version. So that all selected combinations are always build.In order to limit the number of combinations only the oldest and latest supported Eclipse TP are build.
The incompatible combination of Java-11 and Eclipse 2023-06 (aka latest), that matrix cell is excluded.
Because the
coactions/setup-xvfb
can only execute a single command I had to adjust thestrict-release-jdk
a bit so that the the jdk can be configured via an extra property. I didn't found a solution to use the same approach as in the Jenkins file.I tried
But then setup-xvfb only tried to run the command if and failed.
Personally I also find the approach used now simpler to read.
--toolchains releng/toolchains.xml -Pstrict-release-jdk -Dtoolchain.jdk=17
is actually a NoOp and not specifying has the same result since JAVA_HOME points to the same JDK as jdk-17 from the toolchain.Since I found it simpler to read I applied the same approach in the Jenkins workflow, but if you prefer the previous way I'll revert that part.
In order to make the job labels not too long I also adjusted the
os
axis values.You can see the results in my fork at:
https://github.com/HannesWell/eclipse.xtext/actions/runs/4757063052
From #2223 (comment)
AFAIK the workflow resource quota is per organization, so if Xtext would have its own GH-organisation more resources would probably be available.