Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Xtext editor subclasses to control highlighting #3250

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

mx990
Copy link
Contributor

@mx990 mx990 commented Nov 22, 2024

Allow Xtext editor subclasses to control highlighting, for example, to (temporarily) disable semantic highlighting in order to handle very large sources. This avoids having to resort to reflection to access these methods.

Closes #3249

Copy link

github-actions bot commented Nov 22, 2024

Test Results

  6 460 files  ± 0    6 460 suites  ±0   3h 12m 7s ⏱️ +5s
 43 238 tests ± 0   42 653 ✅  - 1    584 💤 ±0   1 ❌ + 1 
170 261 runs  +10  167 903 ✅  - 1  2 336 💤 ±0  22 ❌ +12 

For more details on these failures, see this check.

Results for commit 830c292. ± Comparison against base commit 4eebe72.

♻️ This comment has been updated with latest results.

@mx990 mx990 force-pushed the editorSubclassHighlighting branch from 595cd6f to 462269d Compare November 25, 2024 13:55
@cdietrich
Copy link
Contributor

can you please rebase



Signed-off-by: Martin Jobst <martin.jobst@posteo.de>
@mx990 mx990 force-pushed the editorSubclassHighlighting branch from 462269d to 830c292 Compare November 27, 2024 03:10
@LorenzoBettini
Copy link
Contributor

@szarnekow can we merge this now?

Copy link
Contributor

@szarnekow szarnekow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@szarnekow szarnekow added this to the Release_2.38 milestone Dec 30, 2024
@szarnekow szarnekow merged commit 202291f into eclipse-xtext:main Dec 30, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Xtext editor subclasses to control highlighting
4 participants