Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nightly target platform #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tjeske
Copy link
Contributor

@tjeske tjeske commented Oct 13, 2023

No description provided.

@cdietrich
Copy link
Member

@tjeske can you please rebase the pr

@cdietrich
Copy link
Member

i assume we

  • either need to have two optional deps to the classgraphs
  • ditch support for older 2023-12
  • maybe we can also import classgraph? do we need the reexport?

@szarnekow
Copy link

I didn't understand the suggestion (3)

maybe we can also import classgraph? do we need the reexport?

What you you mean by that?

@cdietrich
Copy link
Member

cdietrich commented Oct 19, 2023

import page should be same accross old/new. (if xtext would have import package)
maybe we also need to change xtext to make import non optional

@cdietrich
Copy link
Member

proposal:

first merge
https://github.com/eclipse/Xpect/compare/cd_classgraph
then rebase this branch
then always pull the new classgraph plugin to the update site (also in the old one)

@szarnekow @tjeske what do you think.
also: should we do an import package on xtext side?

@cdietrich
Copy link
Member

ping @szarnekow

@szarnekow
Copy link

I agree with your proposal. I don't quite understand the relation between Xtext import-package and this PR here.

@cdietrich
Copy link
Member

Relation is indirect. Same problem different place

@cdietrich
Copy link
Member

@szarnekow
Copy link

Ah, that one... Changed bundle ID due to different packaging. Yeah, import package should be preferred for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants