Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che 7: Using a Visual Studio Code extension in Che #754

Merged

Conversation

MichalMaler
Copy link
Contributor

https://issues.jboss.org/browse/RHDEVDOCS-1153
adding content about Using a Visual Studio Code extension in Che -googledoc

rewrote this document into .adoc
https://docs.google.com/document/d/1gZHKXe1GEduY48RgntMUrqjSs9llq8WpCmgqssY5Ikw/edit#heading=h.s7tesxgcl8k3

@MichalMaler
Copy link
Contributor Author

It's ready for SME review @slemeur @l0rd

@MichalMaler
Copy link
Contributor Author

@rkratky @supriya-bharadwaj There seems to be an issue with converting level 3 headings; after rendering, they look like as a plain text.
See the chapter: Adding the VS Code extension using the Che Plugins panel
and Adding the VS Code extension using the workspace configuration

[discrete]
== Prerequisites

* Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve another 512 MB RAM for the VS Code extensions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve another 512 MB RAM for the VS Code extensions.
* Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve an additional 512 MB RAM for the VS Code extensions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichalMaler , the original document does not speak about the additional 512 MB RAM. Can you please confirm that that's what we need here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supriya-bharadwaj Hello! I fix this by rewriting into this shape:
"Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve sufficient memory for the VS code extensions. The specific amount of memory required depends on the extensions used."

[discrete]
== Prerequisites

* Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve another 512 MB RAM for the VS Code extensions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichalMaler , the original document does not speak about the additional 512 MB RAM. Can you please confirm that that's what we need here?

@MichalMaler
Copy link
Contributor Author

Peer review has been done by @supriya-bharadwaj and @jherrmann.redhat.com

@l0rd l0rd mentioned this pull request Jul 24, 2019
85 tasks
@MichalMaler MichalMaler force-pushed the i1153-VS_Code_extension_in_the_Che branch from d3ab9b2 to b4f3c10 Compare July 24, 2019 08:48
@rkratky rkratky changed the title i1153- rewrote the content into adoc Che 7: Using a Visual Studio Code extension in Che Jul 27, 2019
MichalMaler and others added 2 commits July 28, 2019 18:28
@rkratky rkratky force-pushed the i1153-VS_Code_extension_in_the_Che branch from 5c6c60f to 01663e0 Compare July 28, 2019 16:29
@rkratky rkratky merged commit 0ec24f2 into eclipse-che:master Jul 28, 2019
@rkratky
Copy link

rkratky commented Jul 28, 2019

@MichalMaler I added your sign-off line and squashed the review commits.

@MichalMaler MichalMaler deleted the i1153-VS_Code_extension_in_the_Che branch August 6, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants