Add codeready user readonly theme #540
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -489,13 +490,18 @@ func getSpecKeycloakDeployment( | |||
| " && /opt/jboss/docker-entrypoint.sh -b 0.0.0.0 -c standalone.xml" | |||
| command += " -Dkeycloak.profile.feature.token_exchange=enabled -Dkeycloak.profile.feature.admin_fine_grained_authz=enabled" | |||
| if cheFlavor == "codeready" { | |||
| addUsernameReadonlyTheme := "if [ ! -d /opt/eap/themes/codeready-username-readonly ]; then" + | |||
There was a problem hiding this comment.
I love that this project allows 'if product then...' branches -- makes the sync/fork/massaging easier downstream :)
| "context" | ||
| "regexp" | ||
| "strconv" | ||
| "strings" | ||
|
|
||
| "github.com/eclipse/che-operator/pkg/deploy/server" | ||
|
|
There was a problem hiding this comment.
strange spacing and sort order, but I'm not fussed so +1. :D
|
LGTM but not an expert in the code. +1 |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
New changes are detected. LGTM label has been removed. |
| addUsernameReadonlyTheme := "baseTemplate=/opt/eap/themes/base/login/login-update-profile.ftl" + | ||
| " && readOnlyTemplateDir=/opt/eap/themes/codeready-username-readonly/login" + | ||
| " && readOnlyTemplate=${readOnlyTemplateDir}/login-update-profile.ftl" + | ||
| " && if [ ! -d ${readOnlyTemplateDir} ]; then" + | ||
| " mkdir -p ${readOnlyTemplateDir}" + | ||
| " && cp ${baseTemplate} ${readOnlyTemplate}" + | ||
| " && echo \"parent=rh-sso\" > ${readOnlyTemplateDir}/theme.properties" + | ||
| " && sed -i 's|id=\"username\" name=\"username\"|id=\"username\" readonly name=\"username\"|g' ${readOnlyTemplate}; fi" |
There was a problem hiding this comment.
@tolusha could you please calrify when / on which stage this command is executed?
I'm wondering if it is possible to do such a manipulation manually for CRW 2.5
There was a problem hiding this comment.
The command is run inside keycloak pod before keycloak starts up.
I don't see a way how we can do it manually.
Signed-off-by: Anatolii Bazko abazko@redhat.com
Reference issue
https://issues.redhat.com/browse/CRW-1379