Initial contribution #1

sunix · 2018-06-04T07:54:52Z

Provides basic factory client side clone feature

checking factory-id from url
request che factory api to get the factory definition
clone the projects defined in the factory definition
checkout branch if needed

eclipse-che/che#9837
eclipse-che/che#9221

slemeur · 2018-06-04T08:40:59Z

Does it handle parse checkout yet? :)

slemeur · 2018-06-04T08:43:22Z

Can we add a small recording with this ?

sunix · 2018-06-04T09:16:41Z

@slemeur

no parse checkout at the moment, let me know if this is priority and I will create an issue
yes will work on a recording today

evidolob · 2018-06-06T08:44:57Z

browser-app/package.json

+  "theia": {
+    "target": "browser"
+  }
+}


New line is missing

new line is here

evidolob · 2018-06-06T08:45:12Z

che-theia-factory-frontend-extension/src/browser/che-theia-factory-frontend-module.ts

+
+    bind(FactoryTheiaClient).toSelf().inSingletonScope();
+    bind(FrontendApplicationContribution).toDynamicValue(c => c.container.get(FactoryTheiaClient));
+});


New line is missing

evidolob · 2018-06-06T08:45:23Z

che-theia-factory-frontend-extension/src/browser/factory-theia-client.ts

+            });
+        })
+    }
+}


New line is missing

evidolob · 2018-06-06T08:45:43Z

che-theia-factory-frontend-extension/src/browser/types.d.ts

+
+export interface IFactory {
+    workspace: IWorkspaceConfig;
+}


New line is missing

evidolob · 2018-06-06T08:45:48Z

che-theia-factory-frontend-extension/tsconfig.json

+    "include": [
+        "src"
+    ]
+}


New line is missing

evidolob · 2018-06-06T08:45:53Z

electron-app/package.json

+  "theia": {
+    "target": "electron"
+  }
+}


New line is missing

evidolob · 2018-06-06T08:46:00Z

lerna.json

+      "stream": true
+    }
+  }
+}


New line is missing

looks like new line is there

evidolob · 2018-06-06T08:50:48Z

che-theia-factory-frontend-extension/src/browser/factory-theia-client.ts

+                });
+            });
+        })
+    }


Can you, please, rewrite this method with async/await, and maybe split in several, it is hard to read code with so many callbacks

AndrienkoAleksandr · 2018-06-09T11:22:34Z

browser-app/package.json

+  "name": "browser-app",
+  "version": "0.0.0",
+  "dependencies": {
+    "@theia/core": "latest",


Could you use 0.3.10 version everywhere, to prevent potential breaking browser-app and electron-app modules, after newer Theia realeses?

AndrienkoAleksandr · 2018-06-09T11:25:56Z

che-theia-factory-frontend-extension/package.json

+    "@eclipse-che/workspace-client": "latest"
+  },
+  "devDependencies": {
+    "rimraf": "latest",


Use, please, version 2.6.2 or another one approved by Eclipse CQ.

AndrienkoAleksandr · 2018-06-09T11:26:39Z

che-theia-factory-frontend-extension/package.json

+  },
+  "devDependencies": {
+    "rimraf": "latest",
+    "typescript": "latest"


Use, please, version 2.7.2 or another one approved by Eclipse CQ.

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

sunix · 2018-06-21T08:10:00Z

@AndrienkoAleksandr @evidolob I have updated the PR with your feedback. Let me know if it works for you

benoitf · 2018-06-21T08:08:28Z

README.md

+3. Create a new factory from the created workspace.
+4. Edit the factory and select `from a stack` and `Java Theia (OpenShift)`
+5. Edit the configuration and add to the theia machine the environment variable THEIA_PLUGINS


could you please use
THEIA_EXTENSIONS (as THEIA_PLUGINS will now only work with theia plugins)

benoitf · 2018-06-21T08:08:39Z

README.md

+            "env": {
+              "CHE_MACHINE_NAME": "ws/theia",
+              "THEIA_PLUGINS": "che-theia-factory:https://github.com/eclipse/che-theia-factory-extension.git"


could you please use
THEIA_EXTENSIONS (as THEIA_PLUGINS will now only work with theia plugins)

benoitf · 2018-06-21T08:09:23Z

README.md

+## Developing with the browser example
+
+Start watching of the hello world extension.


FYI it's not hello world extension

benoitf · 2018-06-21T08:10:50Z

browser-app/package.json

+    "@theia/terminal": "0.3.11",
+    "@theia/typescript": "0.3.11",
+    "@theia/workspace": "0.3.11",
+    "@eclipse/che-theia-factory": "^0.3.11"


carret should be removed as well
also I'm not sure this extension should use 0.3.11 version , it's the first version so more like 0.0.1 (or something like that)

benoitf · 2018-06-21T08:11:07Z

che-theia-factory/package.json

+  "keywords": [
+    "theia-extension"
+  ],
+  "version": "0.3.11",


benoitf · 2018-06-21T08:15:20Z

che-theia-factory/src/browser/resources.ts

+
+import { AxiosInstance, AxiosPromise } from 'axios';
+
+export interface IResources {


some comments ?

benoitf · 2018-06-21T08:16:01Z

che-theia-factory/src/browser/types.d.ts

+import { IWorkspaceConfig } from "@eclipse-che/workspace-client";
+
+
+export interface IFactory {


do we need this .d.ts ?

benoitf · 2018-06-21T08:19:45Z

electron-app/package.json

@@ -0,0 +1,32 @@
+{


latest here should not be used

benoitf · 2018-06-21T08:20:00Z

electron-app/package.json

+{
+  "private": true,
+  "name": "electron-app",
+  "version": "1.0.2",


version should be the same on the whole project

benoitf · 2018-06-21T08:20:12Z

electron-app/package.json

+    "@theia/terminal": "latest",
+    "@theia/typescript": "latest",
+    "@theia/workspace": "latest",
+    "sunix-che-theia-factory-frontend-extension": "^1.0.2"


something wrong there ?

ok let's remove the electron app what do you think ?

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

AndrienkoAleksandr · 2018-06-22T08:23:39Z

README.md

+Open http://localhost:3000 in the browser.
+
+## Developing with the Electron example


I guess, you should remove this section, because you removed electron package.

AndrienkoAleksandr · 2018-06-22T08:36:28Z

lerna.json

@@ -0,0 +1,11 @@
+{
+  "lerna": "2.4.0",
+  "version": "1.0.2",


You definded version of your extension like 0.0.1: https://github.com/eclipse/che-theia-factory-extension/pull/1/files#diff-2c9e1ab7353b6750c47de1b55b578910R6, so I think here should be the same version

sunix · 2018-06-25T08:07:01Z

@benoitf @eivantsov @AndrienkoAleksandr could you review and approve if it is ok ?

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

benoitf · 2018-06-25T12:42:19Z

che-theia-factory/src/browser/factory-theia-client.ts

+
+/**
+ * Provides basic factory client side features at startup of the browser IDE:
+ * - checking/retriving factory-id from URL


FYI small typo on retrieving

sunix requested review from benoitf, ashumilova, slemeur and evidolob June 4, 2018 08:08

sunix force-pushed the initialContrib branch from 7309542 to 758e3a0 Compare June 5, 2018 07:39

evidolob reviewed Jun 6, 2018

View reviewed changes

AndrienkoAleksandr reviewed Jun 9, 2018

View reviewed changes

sunix mentioned this pull request Jun 15, 2018

Factory in Theia: optimizing che-theia-factory loading eclipse-che/che#10062

Closed

sunix force-pushed the initialContrib branch 2 times, most recently from 6f965e7 to 3049b07 Compare June 21, 2018 07:40

initial contribution

6eb3692

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

sunix force-pushed the initialContrib branch from 3049b07 to 6eb3692 Compare June 21, 2018 07:47

benoitf reviewed Jun 21, 2018

View reviewed changes

sunix added 6 commits June 21, 2018 13:01

removing unused electron app

29f8c8c

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

using THEIA_EXTENSIONS instead of THEIA_PLUGINS

e2ef66a

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

not helloworld extension anymore

23b8cae

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

renamed Resources class to FactoryService

8336563

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

renamed types.d to types

cbeaadd

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

using version 0.0.1 instead of theia version

5bfa9e9

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

AndrienkoAleksandr reviewed Jun 22, 2018

View reviewed changes

sunix added 2 commits June 22, 2018 14:16

fixup! removing unused electron app

3dbc1e9

fixup! using version 0.0.1 instead of theia version

007d04f

AndrienkoAleksandr approved these changes Jun 25, 2018

View reviewed changes

format

eee4bee

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

documentation

3168e7e

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

benoitf reviewed Jun 25, 2018

View reviewed changes

fixup! format

eed0028

sunix merged commit fea05c5 into master Jun 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial contribution #1

Initial contribution #1

sunix commented Jun 4, 2018 •

edited

Loading

slemeur commented Jun 4, 2018

slemeur commented Jun 4, 2018

sunix commented Jun 4, 2018

evidolob Jun 6, 2018

sunix Jun 25, 2018

evidolob Jun 6, 2018

evidolob Jun 6, 2018

evidolob Jun 6, 2018

evidolob Jun 6, 2018

evidolob Jun 6, 2018

evidolob Jun 6, 2018

sunix Jun 25, 2018

evidolob Jun 6, 2018

AndrienkoAleksandr Jun 9, 2018

AndrienkoAleksandr Jun 9, 2018

AndrienkoAleksandr Jun 9, 2018

sunix commented Jun 21, 2018

benoitf Jun 21, 2018

benoitf Jun 21, 2018

benoitf Jun 21, 2018

sunix Jun 21, 2018

benoitf Jun 21, 2018

benoitf Jun 21, 2018

benoitf Jun 21, 2018

benoitf Jun 21, 2018

benoitf Jun 21, 2018

benoitf Jun 21, 2018

benoitf Jun 21, 2018

sunix Jun 21, 2018

AndrienkoAleksandr Jun 22, 2018

AndrienkoAleksandr Jun 22, 2018

sunix commented Jun 25, 2018

benoitf Jun 25, 2018

		## Developing with the browser example

		Start watching of the hello world extension.


		import { AxiosInstance, AxiosPromise } from 'axios';

		export interface IResources {

		import { IWorkspaceConfig } from "@eclipse-che/workspace-client";


		export interface IFactory {

		Open http://localhost:3000 in the browser.

		## Developing with the Electron example

Initial contribution #1

Initial contribution #1

Conversation

sunix commented Jun 4, 2018 • edited Loading

slemeur commented Jun 4, 2018

slemeur commented Jun 4, 2018

sunix commented Jun 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunix commented Jun 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunix commented Jun 25, 2018

Choose a reason for hiding this comment

sunix commented Jun 4, 2018 •

edited

Loading