This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
Initial implementation of the extension #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
requested review from
benoitf,
evidolob,
ashumilova,
AndrienkoAleksandr and
akurinnoy
benoitf
reviewed
May 3, 2018
package.json
Outdated
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "name": "@theia/che-theia-hosted-plugin-manager-extension", | |||
There was a problem hiding this comment.
hello, why is it @theia if it's a che extension ?
There was a problem hiding this comment.
will change for eclipse-che
benoitf
reviewed
May 3, 2018
| "include": [ | ||
| "src" | ||
| ] | ||
| } |
benoitf
reviewed
May 3, 2018
| } | ||
|
|
||
| async processUri(uri: URI): Promise<URI> { | ||
| const hostedPluginTheiaInnstanceServer = await this.getHostedPluginTheiaInnstanceServer(); |
There was a problem hiding this comment.
somehow there are too many n in 'instance' getHostedPluginTheiaInnstanceServer
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "rimraf": "^2.6.2", | ||
| "typescript": "latest" |
There was a problem hiding this comment.
Set up please 2.7.2 version. For this version CQ passed.
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
AndrienkoAleksandr
approved these changes
May 4, 2018
23 tasks
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
|
@benoitf @evidolob @akurinnoy review again please |
benoitf
approved these changes
May 29, 2018
akurinnoy
approved these changes
May 30, 2018
evidolob
approved these changes
May 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension contributes to
HostedPluginManageruri postprocessor which converts internal (inside container) hosted instance uri to external (Che host).