This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
Set correct che api external enviroment variable. Use official released workspace client. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
ashumilova,
azatsarynnyy,
olexii4,
mmorhun and
akurinnoy
azatsarynnyy
approved these changes
May 2, 2018
benoitf
reviewed
May 2, 2018
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
why do we need to skip the check ?
There was a problem hiding this comment.
Without skip check lib build fails.
mmorhun
approved these changes
May 2, 2018
…heck, use strict js. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
olexii4
approved these changes
May 21, 2018
23 tasks
ashumilova
approved these changes
Jun 14, 2018
18 tasks
Apply yarn.lock for reproducible build. Fix incorrect list machines when user open machine panel and do browser page refresh. Synchronize getting workspaceId and che api end point. Code clean up. Update version of @eclipse-che/workspace-client Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
|
@olexii4, @mmorhun take a look again, please. |
olexii4
approved these changes
Jun 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set correct che api external env. variable, because pull request: eclipse-che/che#9475 was merged.
Use official released Eclipse CHE workspace client.
Set skip lib checks to prevent fail build.