This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
Implement terminal exit #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
akurinnoy,
mmorhun,
olexii4 and
azatsarynnyy
benoitf
approved these changes
Nov 14, 2018
azatsarynnyy
approved these changes
Nov 15, 2018
mmorhun
approved these changes
Nov 16, 2018
akurinnoy
approved these changes
Nov 16, 2018
olexii4
approved these changes
Nov 17, 2018
43 tasks
…ion into implementTerminalExit
AndrienkoAleksandr
force-pushed
the
implementTerminalExit
branch
from
7cc5913
to
97ee6b5
Compare
34 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align exit terminal behavior with VScode. For example user could kill terminal by 'kill -9 pid', or type 'exit' in the terminal - in this case extension should close terminal widget.
#Related issue
eclipse-che/che#11789 "The terminal panel should be closed when the user exit"