Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Authorize GitHub requests with header instead of query parameter #924

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Nov 16, 2020

What does this PR do?

Use GitHub Authorisation header in GitHub HTTP requests instead of token in query parameter.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#16425

How to test this PR?

  1. Setup GitHub Identity provider
  2. Start a workspace with GitHub Pull Requests plugin and a project cloned from GitHub by https url.
    You can use this devfile to start a workspace:
apiVersion: 1.0.0
metadata:
  name: wksp-custom-dwdiu
projects:
  - name: che-theia
    source:
      location: 'https://github.com/eclipse/che-theia.git'
      type: git
      branch: master
components:
  - type: chePlugin
    reference: 'https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/v3/plugins/ms-vscode/vscode-github-pullrequest/0.20.0/meta.yaml'
  - type: cheEditor
    reference: 'https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-924/simple/che-theia-editor.yaml'
  1. Sign-in to the GitHub Pull Requests plugin.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@benoitf
Copy link
Contributor

benoitf commented Nov 16, 2020

Hello, the node build is failing

@vinokurig vinokurig force-pushed the che-16425 branch 2 times, most recently from 4542f28 to ff29d06 Compare November 16, 2020 13:47
@che-bot
Copy link
Contributor

che-bot commented Nov 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:924
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:924

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@vinokurig vinokurig force-pushed the che-16425 branch 3 times, most recently from ad1429c to aabec92 Compare November 16, 2020 14:21
@che-bot
Copy link
Contributor

che-bot commented Nov 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:924
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:924

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:924
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:924

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Working and token is used in headers

@benoitf
Copy link
Contributor

benoitf commented Nov 17, 2020

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Nov 17, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:924
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:924

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@benoitf benoitf merged commit fdf8336 into master Nov 17, 2020
@benoitf benoitf deleted the che-16425 branch November 17, 2020 06:57
vinokurig added a commit that referenced this pull request Nov 27, 2020
Backport #924
Use GitHub Authorisation header in GitHub HTTP requests instead of token in query parameter.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants