This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Authorize GitHub requests with header instead of query parameter #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinokurig
requested review from
azatsarynnyy,
benoitf,
RomanNikitenko and
vzhukovs
as code owners
November 16, 2020 13:07
Hello, the node build is failing |
vinokurig
force-pushed
the
che-16425
branch
2 times, most recently
from
November 16, 2020 13:47
4542f28
to
ff29d06
Compare
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
vinokurig
force-pushed
the
che-16425
branch
3 times, most recently
from
November 16, 2020 14:21
ad1429c
to
aabec92
Compare
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
benoitf
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[crw-ci-test] |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
9 tasks
vinokurig
added a commit
that referenced
this pull request
Nov 27, 2020
Backport #924 Use GitHub Authorisation header in GitHub HTTP requests instead of token in query parameter.
22 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use GitHub Authorisation header in GitHub HTTP requests instead of token in query parameter.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#16425
How to test this PR?
https
url.You can use this devfile to start a workspace:
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable