Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard behaves like there are no changes if Devfile editor has invalid yaml #19873

Closed
23 tasks
sleshchenko opened this issue May 27, 2021 · 0 comments · Fixed by eclipse-che/che-dashboard#254
Closed
23 tasks
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@sleshchenko
Copy link
Member

Describe the bug

Dashboard behaves like there are no changes if Devfile editor has invalid yaml.
It allows to switch the tab and Cancel button is not active:
Screenshot_20210524_152939

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Go to Workspace Details # Devfile.
  2. Break yaml
  3. Check that behavior is like described above.

Expected behavior

Tab change is blocked unless user discards changes.
User is able to cancel changes.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

Additional context

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. area/dashboard severity/P2 Has a minor but important impact to the usage or development of the system. labels May 27, 2021
@sleshchenko sleshchenko added this to the 7.32 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant