Fix Devfile Editor #254
Fix Devfile Editor #254
Conversation
Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
✅ E2E dashboard tests succeed 🎉 See Details
Tested with Eclipse Che on K8S (minikube v1.1.1)
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
✅ E2E dashboard tests succeed 🎉 See Details
Tested with Eclipse Che on K8S (minikube v1.1.1)
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
@olexii4 please fix the unit test for the devfile editor. |
| } catch (e) { | ||
| console.error('Devfile parse error', e); | ||
| return; | ||
| } | ||
| if (this.areEqual(this.props.workspace.devfile as che.WorkspaceDevfile, devfile)) { |
There was a problem hiding this comment.
I wonder if now we should start comparing string value somehow, to allow users cancel their empty space changes, like my:
I've created a separate issue for that eclipse-che/che#19882
Codecov Report
@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 49.95% 49.94% -0.01%
==========================================
Files 140 140
Lines 5241 5246 +5
Branches 846 846
==========================================
+ Hits 2618 2620 +2
- Misses 2382 2385 +3
Partials 241 241
Continue to review full report at Codecov.
|
|
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-254 |
|
✅ E2E dashboard tests succeed 🎉 See Details
Tested with Eclipse Che on K8S (minikube v1.1.1)
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Signed-off-by: Oleksii Orel oorel@redhat.com
What does this PR do?
Fix DevfileEditor onChange callback.
What issues does this PR fix or reference?
Fixes eclipse-che/che#19873