Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Che-Theia to upstream changes #19984

Closed
Tracked by #19958
RomanNikitenko opened this issue Jun 16, 2021 · 2 comments
Closed
Tracked by #19958

Adapt Che-Theia to upstream changes #19984

RomanNikitenko opened this issue Jun 16, 2021 · 2 comments
Assignees
@azatsarynnyy
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.33

Comments

@RomanNikitenko
Copy link
Member

Is your task related to a problem? Please describe.

There are breaking changes made in upstream Theia by the commit: eclipse-theia/theia@f9c0311.
The Che Workspace fails, I detected the following problem:

fail_start

it's something related to keytar which was added within eclipse-theia/theia@f9c0311

Describe the solution you'd like

Need to adapt Che-Theia to the upstream changes.
@RomanNikitenko RomanNikitenko added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/editors area/editor/theia Issues related to the che-theia IDE of Che labels Jun 16, 2021
@azatsarynnyy azatsarynnyy self-assigned this Jun 16, 2021
@azatsarynnyy azatsarynnyy added this to the 7.33 milestone Jun 16, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Jun 16, 2021
Closed
10 tasks
@azatsarynnyy
Copy link
Member

Theia now depends on keytar which requires installed libsecret.
Checking... eclipse-che/che-theia@6b900cb

@RomanNikitenko RomanNikitenko mentioned this issue Jun 17, 2021
Merged
9 tasks
@azatsarynnyy
Copy link
Member

Fixed by: eclipse-che/che-theia@6b900cb + eclipse-che/che-theia@ca2038e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.33
Development

No branches or pull requests
2 participants
@azatsarynnyy @RomanNikitenko