chore: Align to upstream changes

[RomanNikitenko]

What does this PR do?

There were breaking changes for che-theia in upstream.
The PR aligns che-theia to upstream changes:

• adapt che-theia to the changes eclipse-theia/theia@aa4fe4a
• adapt che-theia to eclipse-theia/theia@f9c0311
• Install 'libsecret' as it's used by keytar that Theia depends on
• Update git built-in to the version that supports FileDecoration API
• Align Task Service to upstream changes: eclipse-theia/theia@d563b6b
• Update yarn.lock. As result some versions were updated.
  For example, @types/prettier from 2.2.3 to 2.3.0. Formatting changes in the PR is related to this update.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19866
eclipse-che/che#19984

How to test this PR?

• One of the breaking change was related to task system, so Che tasks as well as Theia/VS Code tasks should be tested, especially running tasks and displaying the corresponding output.
• Another breaking change was - Che workspace couldn't start at all, please see Adapt Che-Theia to upstream changes che#19984, so starting a workspace should be tested.
• Activating Git and Github extensions should be fixed, please see chore: Align to upstream changes #1142 (comment)

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

[codecov]

Codecov Report

Merging #1142 (ca2038e) into master (eeb4526) will increase coverage by 3.24%.
The diff coverage is 55.41%.

@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
+ Coverage   29.45%   32.69%   +3.24%     
==========================================
  Files         277      290      +13     
  Lines        9336     9872     +536     
  Branches     1380     1515     +135     
==========================================
+ Hits         2750     3228     +478     
- Misses       6487     6544      +57     
- Partials       99      100       +1     

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	0.00% <ø> (ø)
...e-sync-tracker/src/browser/sync-process-tracker.ts	0.00% <0.00%> (ø)
...ovisioner/src/node/git-configuration-controller.ts	0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts	100.00% <ø> (ø)
...eia-plugin-remote/src/node/hosted-plugin-remote.ts	0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-host-custom.ts	0.00% <0.00%> (ø)
...in-remote/src/node/plugin-remote-backend-module.ts	0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts	0.00% <0.00%> (ø)
...-che-theia-plugin-remote/src/node/plugin-remote.ts	0.00% <0.00%> (ø)
...ugin-remote/src/node/server-plugin-proxy-runner.ts	0.00% <0.00%> (ø)
... and 101 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340363a...ca2038e. Read the comment docs.

[azatsarynnyy]

let's check with the libsecret installed

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1142
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1142

Test product:

• tested with Eclipse Che on K8S (minikube v1.1.1)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[azatsarynnyy]

Now, git built-in fails:

trying to update git built-in to 1.52.1 that should support FileDecoration API eclipse-theia/theia#8911

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1142
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1142

Test product:

• tested with Eclipse Che on K8S (minikube v1.1.1)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[RomanNikitenko]

thank you, Artem, so much for your help and providing additional fixes to align che-theia to upstream changes!

[azatsarynnyy]

I'm checking the UBI image manually to verify that adding libsecret solves the start-up issue.

[benoitf]

@azatsarynnyy it should be covered by
Happy Path / happy-path (ubi8, next) (pull_request) Successful in 52m

[azatsarynnyy]

@azatsarynnyy it should be covered by
Happy Path / happy-path (ubi8, next) (pull_request) Successful in 52m

ahh.. sure, I forgot 🤦‍♂️ Thanks!
So, @RomanNikitenko it's ready for review, I believe.

[benoitf]

tested tasks, git, github, etc and I didn't see issues

[benoitf]

@RomanNikitenko 7.32.0 being already tagged I think we're in a good shape to merge ?

[RomanNikitenko]

@RomanNikitenko 7.32.0 being already tagged I think we're in a good shape to merge ?

yes, sure!
I just wanted to give more time for people if someone would like to test/review the changes...

[benoitf]

yes, sure!
I just wanted to give more time for people if someone would like to test/review the changes...

yes, no issue on that (or pressure to get it merge faster)
Just that when it's the start of a sprint I think we're more open to have some little breakages than at the end of the sprint :-)

[zWingz]

tested tasks, git, github, etc and I didn't see issues

How do you test this PR ?
Build a che-theia docker image from PR and use it as theia-editor in devfile ?

[RomanNikitenko]

How do you test this PR ?
Build a che-theia docker image from PR and use it as theia-editor in devfile ?

this is one of the possible options

but actually for testing a PR changes you don't need to build images - you could use Try it buttons

[RomanNikitenko]

it looks like try it buttons are broken at the moment, but usually it's possible to start a workspace and test changes using the buttons...

[zWingz]

How do you test this PR ?
Build a che-theia docker image from PR and use it as theia-editor in devfile ?

this is one of the possible options

but actually for testing a PR changes you don't need to build images - you could use Try it buttons

That is so cool. but it still build a theia-ide@next image ?
Won't this be overwritten by other theia-ide@next images?

[RomanNikitenko]

Won't this be overwritten by other theia-ide@next images?

You can go to Happy path tests DevFile => the corresponding meta.yaml file to see what images are used for the current PR.
There is a unique version of che-theia image...

[zWingz]

@RomanNikitenko thanks