This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
chore(tasks): Align Task Service to upstream changes #1124
Closed
RomanNikitenko
wants to merge
2
commits into
eclipse-che:master
from
RomanNikitenko:alignTaskServiceToUpstream
Closed
chore(tasks): Align Task Service to upstream changes #1124
RomanNikitenko
wants to merge
2
commits into
eclipse-che:master
from
RomanNikitenko:alignTaskServiceToUpstream
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
===========================================
- Coverage 56.46% 32.58% -23.89%
===========================================
Files 47 286 +239
Lines 2088 9714 +7626
Branches 346 1472 +1126
===========================================
+ Hits 1179 3165 +1986
- Misses 898 6451 +5553
- Partials 11 98 +87
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
RomanNikitenko
added a commit
to RomanNikitenko/che-theia
that referenced
this pull request
Jun 3, 2021
Related issue: eclipse-che/che#19866 Related PR: eclipse-che#1124 Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
alignTaskServiceToUpstream
branch
from
June 3, 2021 12:19
671da4a
to
2ed2c07
Compare
RomanNikitenko
changed the title
Align Task Service to upstream changes
fix(tasks): Align Task Service to upstream changes
Jun 3, 2021
This comment has been minimized.
This comment has been minimized.
9 tasks
RomanNikitenko
added a commit
to RomanNikitenko/che-theia
that referenced
this pull request
Jun 15, 2021
Related issue: eclipse-che/che#19866 Related PR: eclipse-che#1124 Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
alignTaskServiceToUpstream
branch
from
June 15, 2021 12:00
2ed2c07
to
ee127c3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[crw-ci-test --rebuild] |
RomanNikitenko
added a commit
to RomanNikitenko/che-theia
that referenced
this pull request
Jun 16, 2021
Related issue: eclipse-che/che#19866 Related PR: eclipse-che#1124 Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
alignTaskServiceToUpstream
branch
from
June 16, 2021 11:52
0053369
to
1d69436
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
alignTaskServiceToUpstream
branch
from
June 16, 2021 12:53
1d69436
to
3225b38
Compare
RomanNikitenko
changed the title
fix(tasks): Align Task Service to upstream changes
chore(tasks): Align Task Service to upstream changes
Jun 16, 2021
This comment has been minimized.
This comment has been minimized.
Closing in favor of #1142 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Nikitenko rnikiten@redhat.com
The PR depends on eclipse-che/che#19804.
I'm going to to test the changes after fixing eclipse-che/che#19804.
What does this PR do?
There were breaking changes for
che-theia
in upstream.The PR aligns Task Service to upstream changes.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19866
How to test this PR?
Che
tasks as well asTheia
/VS Code tasks should be tested, especially running tasks and displaying the corresponding output.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable