Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

chore(tasks): Align Task Service to upstream changes #1124

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Jun 3, 2021

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

The PR depends on eclipse-che/che#19804.
I'm going to to test the changes after fixing eclipse-che/che#19804.

What does this PR do?

There were breaking changes for che-theia in upstream.
The PR aligns Task Service to upstream changes.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19866

How to test this PR?

Che tasks as well as Theia/VS Code tasks should be tested, especially running tasks and displaying the corresponding output.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #1124 (1d69436) into master (02d0cb0) will decrease coverage by 23.88%.
The diff coverage is 57.10%.

❗ Current head 1d69436 differs from pull request most recent head 3225b38. Consider uploading reports for the commit 3225b38 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1124       +/-   ##
===========================================
- Coverage   56.46%   32.58%   -23.89%     
===========================================
  Files          47      286      +239     
  Lines        2088     9714     +7626     
  Branches      346     1472     +1126     
===========================================
+ Hits         1179     3165     +1986     
- Misses        898     6451     +5553     
- Partials       11       98       +87     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <ø> (ø)
...e-sync-tracker/src/browser/sync-process-tracker.ts 0.00% <0.00%> (ø)
...ovisioner/src/node/git-configuration-controller.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...mini-browser/src/node/che-mini-browser-endpoint.ts 0.00% <0.00%> (ø)
...se-che-theia-plugin-ext/src/common/che-protocol.ts 100.00% <ø> (ø)
...e-che-theia-plugin-ext/src/plugin/che-workspace.ts 56.66% <0.00%> (ø)
...lugin-remote/src/browser/che-plugin-file-system.ts 0.00% <0.00%> (ø)
...emote/src/browser/plugin-remote-frontend-module.ts 0.00% <0.00%> (ø)
...e-theia-plugin-remote/src/common/che-plugin-uri.ts 0.00% <0.00%> (ø)
... and 351 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340363a...3225b38. Read the comment docs.

@che-bot

This comment has been minimized.

RomanNikitenko added a commit to RomanNikitenko/che-theia that referenced this pull request Jun 3, 2021
Related issue: eclipse-che/che#19866
Related PR: eclipse-che#1124

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko changed the title Align Task Service to upstream changes fix(tasks): Align Task Service to upstream changes Jun 3, 2021
@che-bot

This comment has been minimized.

RomanNikitenko added a commit to RomanNikitenko/che-theia that referenced this pull request Jun 15, 2021
Related issue: eclipse-che/che#19866
Related PR: eclipse-che#1124

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@che-bot

This comment has been minimized.

@che-bot

This comment has been minimized.

@che-bot

This comment has been minimized.

@che-bot

This comment has been minimized.

@che-bot

This comment has been minimized.

@RomanNikitenko
Copy link
Member Author

[crw-ci-test --rebuild]

RomanNikitenko added a commit to RomanNikitenko/che-theia that referenced this pull request Jun 16, 2021
Related issue: eclipse-che/che#19866
Related PR: eclipse-che#1124

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@che-bot

This comment has been minimized.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko changed the title fix(tasks): Align Task Service to upstream changes chore(tasks): Align Task Service to upstream changes Jun 16, 2021
@che-bot

This comment has been minimized.

@RomanNikitenko
Copy link
Member Author

Closing in favor of #1142

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants