'Try it' buttons on Che Theia PR are not working

[RomanNikitenko]

Describe the bug

I'm not able to start a workspace using Try it buttons.
The error is:

Cause: Devfile schema validation failed. Error: (/metadata):The value must be of object type, but actual type is null.(/generateName):The object must not have a property whose name is "generateName".(/projects/0):The object must have a property whose name is "source".(/source):The object must not have a property whose name is "source".(/type):The object must not have a property whose name is "type".(/location):The object must not have a property whose name is "location".(/branch):The object must not have a property whose name is "branch".(/components/0):The object must have a property whose name is "type".

Che version

• nightly

Steps to reproduce

Try to use Try it buttons on a PR to che-theia

The URL is like the following:
https://workspaces.openshift.com/f?url=https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1161/simple/che-theia-simple-devfile.yaml

Screenshots

[sleshchenko]

As far as I see it happens due broken yaml:

> curl https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1161/simple/che-theia-simple-devfile.yaml

apiVersion: 1.0.0
metadata:
generateName: pr-che_theia-1161-
projects:
- name: pr-1161
source:
type: git
location: 'https://github.com/eclipse-che/che-theia.git'
branch: 'dontSetPublicUrlValueToInternalUrlSettings'
components:
- reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1161/simple/che-theia-editor.yaml
type: cheEditor

^ spaces are missing, it should be like:

apiVersion: 1.0.0
metadata:
  generateName: pr-che_theia-1161-
projects:
- name: pr-1161
source:
  type: git
  location: 'https://github.com/eclipse-che/che-theia.git'
  branch: 'dontSetPublicUrlValueToInternalUrlSettings'
components:
- reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1161/simple/che-theia-editor.yaml
  type: cheEditor

I'm not sure who owns chepullreq4/pr-check-files, adding che theia area.

[RomanNikitenko]

I'm not sure who owns chepullreq4/pr-check-files

I'm not sure as well, maybe @dmytro-ndp knows...

[dmytro-ndp]

@RomanNikitenko: Che QE team is responsible for Che Theia PR check on CRW Jenkins including Try it buttons.

[dmytro-ndp]

@sleshchenko: thanks for the root cause analysis!

Small remark: source is projects property and so should be placed at the projects level:

apiVersion: 1.0.0
metadata:
  generateName: pr-che_theia-1161-
projects:
- name: pr-1161
  source:
    type: git
    location: 'https://github.com/eclipse-che/che-theia.git'
    branch: 'dontSetPublicUrlValueToInternalUrlSettings'
components:
- reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1161/simple/che-theia-editor.yaml
  type: cheEditor

[dmytro-ndp]

Fixed in CRW Jenkins source code https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/merge_requests/675

[RomanNikitenko]

@dmytro-ndp
could you take a look please, I'm able to reproduce the problem again for the test PR without any changes.

The error is:

Failed to resolve a devfile. Error occurred during creation a workspace from devfile located at `https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1049/simple/che-theia-nodejs-devfile.yaml`. Cause: Devfile schema validation failed. Error: (/attributes/persistVolumes):The value must be of string type, but actual type is boolean.

[RomanNikitenko]

It looks like the cause of the problem is: #20153
thanks @skabashnyuk for an investigation...

[dmytro-ndp]

@RomanNikitenko : thanks for update.
I am closing an issue then.

[RomanNikitenko]

@dmytro-ndp
according to #20153 (comment) should we reopen the current issue?

[dmytro-ndp]

@RomanNikitenko: "Try it" buttons are linked with devfiles with:

   persistVolumes: false

The correct variant:

  persistVolumes: "false"

Let's reopen an issue and fix the devfile templates.

[RomanNikitenko]

should be fixed by https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/merge_requests/696
thanks @dmytro-ndp