Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's not possible to install not sidecar plugin via devfile v2 #20718

Closed
svor opened this issue Nov 2, 2021 · 3 comments
Closed

It's not possible to install not sidecar plugin via devfile v2 #20718

svor opened this issue Nov 2, 2021 · 3 comments
Assignees
Labels
area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@svor
Copy link
Contributor

svor commented Nov 2, 2021

Describe the bug

If extensions.json file contains plugins which are not sidecar for example dbaeumer.vscode-eslint, they won't be installed in the workspace.

Che version

7.38@latest

Steps to reproduce

Try to start the forkspace form this sample https://github.com/svor/web-nodejs-sample/tree/noplugins.
The content of extensions.json is

{
    // See https://go.microsoft.com/fwlink/?LinkId=827846
    // for the documentation about the extensions.json format
    "recommendations": [
        "dbaeumer.vscode-eslint"
    ]
}

Expected behavior

The plugins should be installed

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/next

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

@svor svor added kind/bug Outline of a bug - must adhere to the bug report template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/plugins severity/P2 Has a minor but important impact to the usage or development of the system. labels Nov 2, 2021
@benoitf
Copy link
Contributor

benoitf commented Nov 2, 2021

from what I see,

  1. download script is not analyzing the theia component now as this one is inside a plug-in
  2. it fails on empty array of attribute vscode-extensions so it tries to curl tons of dummy files

@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Nov 4, 2021
@l0rd
Copy link
Contributor

l0rd commented Nov 4, 2021

@svor this looks critical to me. I have set severity/P1.

@benoitf
Copy link
Contributor

benoitf commented Nov 5, 2021

fixed

@benoitf benoitf closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants