CHE-12918 add checks for incompatible factories

[olexii4]

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Show an error message in the case with incompatible CHE 6 factory. Reject incompatible factories resolving.

What issues does this PR fix or reference?

#12918

Signed-off-by: Oleksii Orel oorel@redhat.com

[olexii4]

@slemeur WDYT?

[slemeur]

LGTM

[olexii4]

ci-test

[che-bot]

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13446
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[skabashnyuk]

@olexii4 Does this pr make all persistent factories incompatible because they are not using devfile?

[olexii4]

@skabashnyuk No, it doesn't persistent all factories as incompatible. Only factories which include a CHE 6 workspace(with installers)

[olexii4]

@skabashnyuk Should I add devfile checks as a mandatory for both objects(workspace and factory)? Could you write an algorithm to check CHE 7 compatible workspaces and factories?

[skabashnyuk]

I think it should be a check of the existence of a devfile object in the workspace and factory objects.
At this moment we have it for workspaces https://github.com/eclipse/che/blob/master/wsmaster/che-core-api-workspace-shared/src/main/java/org/eclipse/che/api/workspace/shared/dto/WorkspaceDto.java#L32 but we don't have it for factories. We are planning to introduce it as part of #13423

[ashumilova]

This particular issue is about detecting "Che6" factories and notifying the user about them, as part of deprecation process. When devfile is introduced as part of the factory object, then we need to adjust following changes. But that fact doesn't block following PR to be merged. And for some period we will still be allowing to use workspaces with config.