Use the metadata.name instead of name. #13513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
ashumilova
reviewed
Jun 11, 2019
| @@ -334,7 +334,6 @@ declare namespace che { | |||
|
|
|||
| export interface IWorkspaceDevfile { | |||
| apiVersion: string; | |||
| name: string; | |||
There was a problem hiding this comment.
should we add here metadata field?
There was a problem hiding this comment.
It's there:
Is it defined ok like that?
There was a problem hiding this comment.
got it, thank you. missed that , sorry
ashumilova
approved these changes
Jun 11, 2019
benoitf
approved these changes
Jun 11, 2019
mkuznyetsov
approved these changes
Jun 12, 2019
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a followup of #13490 to fix the dashboard and pick up the name of the devfile from the correct place.