Support mountSources for K8S/OS components in devfile #13595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
amisevsk,
ibuziuk,
metlos and
sleshchenko
as code owners
sleshchenko
reviewed
Jun 20, 2019
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
amisevsk
reviewed
Jun 20, 2019
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
|
ci-test |
sleshchenko
approved these changes
Jun 21, 2019
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
Show resolved
Hide resolved
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
ci-build |
amisevsk
approved these changes
Jun 21, 2019
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1877//Selenium_20tests_20report/) doesn't show any regression against this Pull Request. |
che-bot
added
the
kind/task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support of mountSources property for K8S/OS components in devfile.
This will mount project sources into each container of single- or multicontainer K8S/OS pods.
What issues does this PR fix or reference?
#12554
Release Notes
N/A
Docs PR
N/A