-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mountSources for non-plugin tools in devfile #12554
Comments
It is already implemented for dockerimage tool in the following PR #12649 |
The issue with - type: kubernetes
alias: employee-manager
reference: deploy_k8s.yaml
sourcesMounts:
- parentName: podName
parentSelector:
labelKey: labelValue
containerName: nodejs-app The issue with such format - it is not clear how to specify sourceMounts for all containers of a component. The possible resolutions of this issue that I see:
@skabashnyuk @metlos @mshaposhnik @l0rd WDYT? [1] https://github.com/sleshchenko/NodeJS-Sample-App/blob/master/devfile.yaml |
@sleshchenko I would not change that now. Your issue makes sense but the solution you propose is still complicated. And I don't consider it urgent because multi-pod workspaces are still not supported currently and for multi-container components we can just continue mounting sources on all containers (or splitted the multi-container component in multiple components with a single container). |
@sleshchenko @skabashnyuk @metlos I figure out that my comment above may be misleading. What I wanted to say is:
|
The che plugins can now specify whether or not they want to have the root of source directories mounted
to their containers using the
mountSources
attribute (which causes the volume with sources to be mounted into the container on location specified by theCHE_PROJECTS_ROOT
env variable available to the container).We should also add this functionality to devfile to support the same mechanism for tools that are not implemented using a che plugin.
dockerImage
type (all it has to understand is theCHE_PROJECTS_ROOT
variable).The text was updated successfully, but these errors were encountered: