-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of dockerimage tool in Devfile #12649
Conversation
4067583
to
5d0e44a
Compare
...le/src/main/java/org/eclipse/che/api/devfile/server/validator/DevfileIntegrityValidator.java
Outdated
Show resolved
Hide resolved
...ore-api-devfile/src/main/java/org/eclipse/che/api/devfile/server/DockerimageToolApplier.java
Show resolved
Hide resolved
...ore-api-devfile/src/main/java/org/eclipse/che/api/devfile/server/DockerimageToolApplier.java
Outdated
Show resolved
Hide resolved
wsmaster/che-core-api-devfile/src/main/resources/schema/devfile.json
Outdated
Show resolved
Hide resolved
d6b344b
to
21c699f
Compare
21c699f
to
039b838
Compare
@mshaposhnik I've fixed/answered your comments and added an ability to export workspace with dockerimage recipe. Please review again. |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
...ore-api-devfile/src/main/java/org/eclipse/che/api/devfile/server/DockerimageToolApplier.java
Outdated
Show resolved
Hide resolved
...ore-api-devfile/src/main/java/org/eclipse/che/api/devfile/server/DockerimageToolApplier.java
Outdated
Show resolved
Hide resolved
...ore-api-devfile/src/main/java/org/eclipse/che/api/devfile/server/DockerimageToolApplier.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
347abb2
to
61f0968
Compare
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
61f0968
to
0e2d650
Compare
What does this PR do?
The main purpose of this PR is adding support of dockerimage tool in Devfile.
But it also contains the following Devfile API improvements:
devfile.json
or validator implementation we use (I faced an issue that we declare our devfile.json as JSON Spec 07 Draft but validator that we use don't supportif/then/else
statements and just skip them.It also allows seeing an error message that is thrown by a validator in the source code, like
instance failed to match exactly one schema (matched 0 out of 3)
whenchePlugin
tool does not have id required field. It is a definitely confusing message and we should consider rewritingdevfile.json
/use another validator/customize current one to make a message more clear.As an example of
che-in-che
Devfile with dockerimageChe-in-Che Devfile with dockerimage tool used
To test changes the following link might be used
{CHE_HOST}/f?url=https://github.com/sleshchenko/che/tree/dockerimage-che-in-che
What issues does this PR fix or reference?
#12389
Release Notes
Added support of
dockerimage
tool in Devfile. It allows defining one container tool much easier than using other tools types. The detailed description of Devfile format see https://redhat-developer.github.io/devfile.Docs PR
I think
devfile.json
contains all the needed changes.