-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Devfile Demo #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
reviewed
Apr 24, 2019
sunix
reviewed
Apr 25, 2019
This comment has been minimized.
This comment has been minimized.
@dneary I cannot request a review from you, but your review would be useful as well. |
amisevsk
approved these changes
May 17, 2019
After discussion with @l0rd was decided to merge this PR as is since there are a couple of people who are reusing this demo and doing it from the master branch is more convenient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR that contains Devfile Demo.
It's a demo that shows how to create Devfile for live application with chectl and then how to use it.
Faced issues
It's needed to edit generated devfile to make it usable for development. Nice to improve this part.
that waits for another component, like mongo database. This topic should be investigated more. Maybe it's good enough just to manually remove init containers is such case.
chectl
, auto pick upCHE_
env vars. Nowscript.md
usedeploy_che.sh
script since it more convenient since it has such feature.Ingress
is used to make the application available. But Ingress has an issue sincehost
should be hardcoded. So, you have to update host if your K8s/OS installation host is different from192.168.99.100
and you're not able to deploy two NodeJS application in two different namespaces.