Make plugins/editors show one entry for each plugin with a drop down for version #13942

JPinkney · 2019-07-22T02:56:42Z

What does this PR do?

This PR introduces the functionality and styling for having plugins/editors show one entry for each plugin, with a drop down to select the version. Previously, the plugins page and the editors page showed an entry for every version of the plugin.

Video: https://www.youtube.com/watch?v=WkrbTsrjuBk

What issues does this PR fix or reference?

#13566

Release Notes

Modified plugin and editor dashboard pages to have one entry for each plugin with a drop down to select the version

che-bot · 2019-07-22T02:56:44Z

Can one of the admins verify this patch?

che-bot · 2019-07-22T02:56:44Z

Can one of the admins verify this patch?

…versions Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>

musienko-maxim · 2019-07-22T03:15:16Z

Can one of the admins verify this PR?

l0rd · 2019-07-22T08:20:26Z

@JPinkney thanks!

@ashumilova @rhopp can you please have a look. If you consider that it's safe enough I would rather be +1 to merge this PR because it has an important impact on UX (even if it isn't inclued in the endgame).

slemeur · 2019-07-23T06:17:14Z

Nice work @JPinkney !

Ping @ashumilova and @rhopp . That is something we would like to integrate in 7.0.0

ashumilova · 2019-07-23T07:43:21Z

Reviewed and like the proposed changes and +1 for merging.
One thing discovered and need to be fixed - when workspace is updated in devfile editor and saved, than the state of plugins and editors pages is not consistent, until user refreshes the page.

benoitf · 2019-07-23T13:59:18Z

I would not merge it, it's an enhancement, linked issue is not event tagged for 7.0.0

nickboldt

So recapping that's a +1 from Anna (with a requested change) and a -1 from Florent.

I suppose @rhopp is the tiebreaker here?

Unclear why I'm being asked to PR review on this one, but here we go:

code: +0, I'm not an expert
concept:+1, makes UI cleaner and appears to sync between the plugins and devfile tabs/content.
QE: -0.5: might break existing UI tests, but not my call.

rhopp · 2019-07-24T11:45:50Z

ci-test

che-bot · 2019-07-24T12:28:30Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13942
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

vitaliy-guliy · 2019-07-24T12:29:32Z

I would display the version as a plain text and display the select field only when hovering the row.
@JPinkney could you please try to play with it. You would like this behavior.

slemeur · 2019-07-26T13:33:51Z

I like @JPinkney proposal as it is. If the select box was appearing only on hover, I would not understand that I can change the version. Here it is clear IMO.

+1 to merge for 7.0.0 if @rhopp and @ashumilova are fine too.

benoitf

target was 7.1.0 but it has been changed to 7.0.0 so I'm fine

ashumilova · 2019-07-29T11:14:10Z

yeah, but need to fix the way how plugins and editors pages are updated on changes in devfile (in editor).

ashumilova · 2019-08-08T09:58:26Z

When we do updates in Yaml editor on "Devfile" page of workspace details, the following method is called:
https://github.com/eclipse/che/blob/d89cf6f0c3b28671cfcef1cfbc4344ca4d110d1d/dashboard/src/app/workspaces/workspace-details/workspace-plugins/workspace-plugins.controller.ts#L71

it has a check, whether plugin is selected (isPluginEnabled).
If we had plugin1/version1 selected, and user changed in editor to plugin1/version2, the check works wrong in that case. We need to find plugin id without version and if there are version changes - keep the item selected with the changed version.

JPinkney · 2019-08-08T13:03:58Z

I'll try to fix that as soon as possible but I'm currently working on the last blocker for Che 7 (#13427) so I can't give any accurate timeline on when it will be done

akurinnoy · 2019-08-08T13:27:05Z

@JPinkney seems there is minor fix so I could prepare a commit with fix. You'll only need to test it and merge, wdyt?

JPinkney · 2019-08-08T13:41:25Z

@akurinnoy Yeah that would be great!

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

akurinnoy · 2019-08-09T07:21:48Z

ci-test

che-bot · 2019-08-09T07:22:20Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:13942
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

akurinnoy · 2019-08-09T07:31:18Z

@rhopp I've just added commit which fixes bug mentioned here

It seems happy-path-tests are not happy with that. Is this fail related to my commit? Is there something I could do to fix it?

dmytro-ndp · 2019-08-09T09:55:14Z

@akurinnoy: PR check has been failed because it uses Jenkinsfile now, which has been merged in master tonight. So, it requires to take changes from master.

…tors

dmytro-ndp · 2019-08-09T11:21:25Z

ci-test

che-bot · 2019-08-09T11:42:54Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:13942
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot · 2019-08-09T12:03:30Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13942
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot · 2019-08-09T12:05:01Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:13942
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2019-08-09T12:14:15Z

ci-test

che-bot · 2019-08-09T12:54:03Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13942
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

JPinkney · 2019-08-09T13:18:39Z

@akurinnoy I've just tested out your fix and it seems like everything is working!

che-bot · 2019-08-09T13:44:59Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:13942
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot · 2019-08-09T22:56:12Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:13942

akurinnoy · 2019-08-13T10:10:41Z

ci-build

akurinnoy · 2019-08-13T11:38:36Z

@rhopp please have a look. Can we merge this PR?

rhopp · 2019-08-15T09:24:44Z

Looking good with one small drawback with the scrolling:

I'm using Google Chrome 76.0.3809.87.

akurinnoy · 2019-08-15T10:00:38Z

@rhopp I'm sure issue with scrolling is not related to this changes. Please file an issue for this bug.

amisevsk · 2019-08-15T21:50:00Z

@rhopp @akurinnoy I can confirm that the scrolling issue is present most versions of Che, I've opened issue #14256

Make plugins/editors show one entry for each plugin with a drop down for version

JPinkney requested review from ashumilova, benoitf, l0rd, nickboldt and rhopp as code owners July 22, 2019 02:56

Plugins and editors are now unified and have a dropdown for multiple …

d89cf6f

…versions Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>

JPinkney force-pushed the unified-plugins-editors branch from 6ed6443 to d89cf6f Compare July 22, 2019 02:57

slemeur mentioned this pull request Jul 23, 2019

plugin panel: Plugin view shouldn't show all the version of the plugin #13913

Closed

nickboldt added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 23, 2019

nickboldt approved these changes Jul 23, 2019

View reviewed changes

benoitf approved these changes Jul 29, 2019

View reviewed changes

che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 8, 2019

fix updating plugins and editors list on workspace page

250a579

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

akurinnoy mentioned this pull request Aug 9, 2019

fix updating plugins and editors list JPinkney/che#11

Merged

eclipse-che deleted a comment from che-bot Aug 9, 2019

Merge remote-tracking branch 'origin/master' into unified-plugins-edi…

ed9a22d

…tors

gorkem mentioned this pull request Aug 14, 2019

Impossible to scroll in plugin list on dashboard #14211

Closed

23 tasks

amisevsk mentioned this pull request Aug 15, 2019

Scrolling dashboard down shows grey backgroud #14256

Closed

3 tasks

akurinnoy merged commit 87d4a10 into eclipse-che:master Aug 16, 2019

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 16, 2019

che-bot added this to the 7.1.0 milestone Aug 16, 2019

l0rd mentioned this pull request Aug 21, 2019

Dashboard plugins list should show one entry for each plugin, with a dropdown to select version. #13566

Closed

skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020

Merge pull request #13942 from JPinkney/unified-plugins-editors

332c5e1

Make plugins/editors show one entry for each plugin with a drop down for version

Make plugins/editors show one entry for each plugin with a drop down for version #13942

Make plugins/editors show one entry for each plugin with a drop down for version #13942

Conversation

JPinkney commented Jul 22, 2019

What does this PR do?

What issues does this PR fix or reference?

Release Notes

che-bot commented Jul 22, 2019

che-bot commented Jul 22, 2019

musienko-maxim commented Jul 22, 2019

l0rd commented Jul 22, 2019

slemeur commented Jul 23, 2019

ashumilova commented Jul 23, 2019

benoitf commented Jul 23, 2019

nickboldt left a comment

Choose a reason for hiding this comment

rhopp commented Jul 24, 2019

che-bot commented Jul 24, 2019

vitaliy-guliy commented Jul 24, 2019 • edited Loading

slemeur commented Jul 26, 2019 • edited Loading

benoitf left a comment

Choose a reason for hiding this comment

ashumilova commented Jul 29, 2019

ashumilova commented Aug 8, 2019 • edited Loading

JPinkney commented Aug 8, 2019

akurinnoy commented Aug 8, 2019

JPinkney commented Aug 8, 2019

akurinnoy commented Aug 9, 2019

che-bot commented Aug 9, 2019

akurinnoy commented Aug 9, 2019

dmytro-ndp commented Aug 9, 2019 • edited Loading

dmytro-ndp commented Aug 9, 2019

che-bot commented Aug 9, 2019

che-bot commented Aug 9, 2019

che-bot commented Aug 9, 2019

dmytro-ndp commented Aug 9, 2019

che-bot commented Aug 9, 2019

JPinkney commented Aug 9, 2019

che-bot commented Aug 9, 2019

che-bot commented Aug 9, 2019

akurinnoy commented Aug 13, 2019

akurinnoy commented Aug 13, 2019

rhopp commented Aug 15, 2019

akurinnoy commented Aug 15, 2019

amisevsk commented Aug 15, 2019

vitaliy-guliy commented Jul 24, 2019 •

edited

Loading

slemeur commented Jul 26, 2019 •

edited

Loading

ashumilova commented Aug 8, 2019 •

edited

Loading

dmytro-ndp commented Aug 9, 2019 •

edited

Loading