Add target="_blank" to the link for "Make a wish" button. #14037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monaka
requested review from
ashumilova,
benoitf,
l0rd,
nickboldt and
rhopp
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this PR? |
monaka
added
the
kind/enhancement
ashumilova
approved these changes
Jul 29, 2019
|
Removing label |
che-bot
added
the
status/code-review
…036) Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
|
@l0rd I did it. |
|
ci-build |
che-bot
removed
the
status/code-review
amisevsk
added a commit
to redhat-developer/rh-che
that referenced
this pull request
Aug 28, 2019
Include fixes for - UD scrolling - Upstream PR eclipse-che/che#14307 - Add 'target="_blank"' for make a wish button: - Upstream PR eclipse-che/che#14037 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Katka92
pushed a commit
to Katka92/rh-che
that referenced
this pull request
Sep 3, 2019
Include fixes for - UD scrolling - Upstream PR eclipse-che/che#14307 - Add 'target="_blank"' for make a wish button: - Upstream PR eclipse-che/che#14037 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
pushed a commit
to redhat-developer/rh-che
that referenced
this pull request
Sep 6, 2019
Include fixes for - UD scrolling - Upstream PR eclipse-che/che#14307 - Add 'target="_blank"' for make a wish button: - Upstream PR eclipse-che/che#14037 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
pushed a commit
to redhat-developer/rh-che
that referenced
this pull request
Sep 6, 2019
Include fixes for - UD scrolling - Upstream PR eclipse-che/che#14307 - Add 'target="_blank"' for make a wish button: - Upstream PR eclipse-che/che#14037 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
…036) (#14037) Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masaki Muranaka monaka@monami-ya.com
What does this PR do?
Adds target="_blank" to the link for "Make a wish" button.
What issues does this PR fix or reference?
fixes #14036