Allow chePlugin preferences to be string, int or boolean type #14174

mshaposhnik · 2019-08-09T07:45:41Z

What does this PR do?

Changes preferences storage model to allow mixed types

What issues does this PR fix or reference?

Release Notes

Docs PR

che-bot · 2019-08-09T07:45:54Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14174
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

...e/src/main/java/org/eclipse/che/api/workspace/server/model/impl/devfile/ObjectConverter.java

dmytro-ndp · 2019-08-09T10:14:01Z

@mshaposhnik: recent PR check has been failed because it uses Jenkinsfile now, which has been merged into master tonight. So, it requires to take changes from master.

che-bot · 2019-08-12T11:05:04Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14174
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2019-08-12T11:17:10Z

@mshaposhnik : PR check #14174 (comment) failed, because PR isn't synchronized with master branch.

che-bot · 2019-08-12T13:06:06Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14174
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot · 2019-08-12T14:35:50Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14174
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot · 2019-08-12T14:42:41Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14174
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

sparkoo

How does it handle Che update 7.0 -> 7.1?

...pace/src/main/java/org/eclipse/che/api/workspace/server/devfile/PreferencesDeserializer.java

...kspace/src/main/java/org/eclipse/che/api/workspace/server/devfile/SerializableConverter.java

...api/workspace/server/devfile/convert/component/plugin/PluginComponentToWorkspaceApplier.java

...workspace/server/devfile/convert/component/plugin/PluginComponentToWorkspaceApplierTest.java

...pi-workspace/src/test/java/org/eclipse/che/api/workspace/server/jpa/JpaWorkspaceDaoTest.java

...-sql-schema/src/main/resources/che-schema/7.0.0-beta8.0-RC5.0/1__change_preferences_type.sql

che-bot · 2019-08-15T10:59:14Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14174

che-bot · 2019-08-15T14:55:56Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14174
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot · 2019-08-15T15:15:18Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14174

amisevsk

Generally looking good, a few comments below.

...pace/src/main/java/org/eclipse/che/api/workspace/server/devfile/PreferencesDeserializer.java

...kspace/src/main/java/org/eclipse/che/api/workspace/server/devfile/SerializableConverter.java

wsmaster/che-core-api-workspace/src/main/resources/schema/devfile.json

.../src/test/java/org/eclipse/che/api/workspace/server/devfile/PreferencesDeserializerTest.java

mshaposhnik · 2019-08-16T07:43:24Z

ci-test

che-bot · 2019-08-16T08:05:34Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14174
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot · 2019-08-16T08:25:50Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14174
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot · 2019-08-16T08:40:41Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14174
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot · 2019-08-16T09:12:49Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14174
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-08-16T09:33:07Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14174

che-bot · 2019-08-16T09:45:43Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14174
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

SkorikSergey · 2019-08-16T09:49:32Z

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2005//Selenium_20tests_20report/) doesn't show any regression against this Pull request.

che-bot · 2019-08-16T10:11:55Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14174

che-bot · 2019-08-16T10:23:29Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14174
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

sleshchenko

Good job! 👍

wsmaster/integration-tests/postgresql-tck/src/test/java/PostgreSqlTckModule.java

wsmaster/integration-tests/mysql-tck/src/test/java/MySqlTckModule.java

che-bot · 2019-08-16T11:31:02Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14174

che-bot · 2019-08-16T12:03:17Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14174
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

mshaposhnik added 2 commits August 7, 2019 16:58

Change pref type to object

fec0e34

Added converter

a5f917d

che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 9, 2019

tolusha reviewed Aug 9, 2019

View reviewed changes

...e/src/main/java/org/eclipse/che/api/workspace/server/model/impl/devfile/ObjectConverter.java Outdated Show resolved Hide resolved

mshaposhnik commented Aug 9, 2019

View reviewed changes

...e/src/main/java/org/eclipse/che/api/workspace/server/model/impl/devfile/ObjectConverter.java Outdated Show resolved Hide resolved

sparkoo reviewed Aug 9, 2019

View reviewed changes

...e/src/main/java/org/eclipse/che/api/workspace/server/model/impl/devfile/ObjectConverter.java Outdated Show resolved Hide resolved

mshaposhnik added 2 commits August 12, 2019 14:04

Store preferences as serializable

51072a5

Store preferences as serializable

c64972c

Code fixups

e17ecc4

Code refactorings

d053fd5

Code refactorings

4124a39

sparkoo requested changes Aug 13, 2019

View reviewed changes

mshaposhnik added 4 commits August 13, 2019 10:39

Code fixups

9ce061b

Revert to json serialization

4657360

Merge branch 'master' into object_prefs

cf6f407

Merge branch 'master' into object_prefs

3b779ba

Code fixes & test

bc38ec7

mshaposhnik marked this pull request as ready for review August 15, 2019 12:04

mshaposhnik requested review from l0rd, metlos, nickboldt and rhopp as code owners August 15, 2019 12:04

Add entities

acd6c9a

mshaposhnik requested a review from amisevsk as a code owner August 15, 2019 14:02

amisevsk reviewed Aug 15, 2019

View reviewed changes

Fix reviews

5e2f2ef

mshaposhnik added 2 commits August 16, 2019 11:41

Merge branch 'master' into object_prefs

50dc2e2

Add addClass() to the persistmodule builder

3e9b4bc

fixup! Add addClass() to the persistmodule builder

0fdb85b

sleshchenko approved these changes Aug 16, 2019

View reviewed changes

wsmaster/integration-tests/postgresql-tck/src/test/java/PostgreSqlTckModule.java Outdated Show resolved Hide resolved

wsmaster/integration-tests/mysql-tck/src/test/java/MySqlTckModule.java Outdated Show resolved Hide resolved

Fix integration module

f728780

metlos approved these changes Aug 16, 2019

View reviewed changes

mshaposhnik merged commit ba1c521 into master Aug 16, 2019

che-bot added this to the 7.1.0 milestone Aug 16, 2019

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 16, 2019

tolusha mentioned this pull request Aug 16, 2019

Impossible to set boolean value for preferences via devfile #14131

Closed

23 tasks

amisevsk mentioned this pull request Aug 23, 2019

Add the devfile to work with c/c++ stack eclipse-che/che-devfile-registry#73

Merged

mshaposhnik deleted the object_prefs branch February 18, 2020 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow chePlugin preferences to be string, int or boolean type #14174

Allow chePlugin preferences to be string, int or boolean type #14174

mshaposhnik commented Aug 9, 2019

che-bot commented Aug 9, 2019

dmytro-ndp commented Aug 9, 2019

che-bot commented Aug 12, 2019

dmytro-ndp commented Aug 12, 2019

che-bot commented Aug 12, 2019

che-bot commented Aug 12, 2019

che-bot commented Aug 12, 2019

sparkoo left a comment

che-bot commented Aug 15, 2019

che-bot commented Aug 15, 2019

che-bot commented Aug 15, 2019

amisevsk left a comment

mshaposhnik commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

SkorikSergey commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

sleshchenko left a comment

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

Allow chePlugin preferences to be string, int or boolean type #14174

Allow chePlugin preferences to be string, int or boolean type #14174

Conversation

mshaposhnik commented Aug 9, 2019

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

che-bot commented Aug 9, 2019

dmytro-ndp commented Aug 9, 2019

che-bot commented Aug 12, 2019

dmytro-ndp commented Aug 12, 2019

che-bot commented Aug 12, 2019

che-bot commented Aug 12, 2019

che-bot commented Aug 12, 2019

sparkoo left a comment

Choose a reason for hiding this comment

che-bot commented Aug 15, 2019

che-bot commented Aug 15, 2019

che-bot commented Aug 15, 2019

amisevsk left a comment

Choose a reason for hiding this comment

mshaposhnik commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

SkorikSergey commented Aug 16, 2019

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019

sleshchenko left a comment

Choose a reason for hiding this comment

che-bot commented Aug 16, 2019

che-bot commented Aug 16, 2019