Update default plugin/devfile registries to use prod-preview #14267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the default registries used in che.properties to use the prod-preview deployments instead of production. This is to avoid issues where snapshot changes of registries and che defaults are incompatible with the deployment on production. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
requested review from
ibuziuk,
l0rd,
nickboldt and
rhopp
as code owners
che-bot
added
status/code-review
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
rhopp
approved these changes
Aug 19, 2019
|
hmm... I thought the plan was not to use OSIO registries at all by default, but rather deploy them together with Che Server |
ibuziuk
reviewed
Aug 19, 2019
ibuziuk
approved these changes
Aug 20, 2019
|
@ibuziuk Yeah this is definitely to be a temporary solution, since rolling out nightlies of the registries will only work going forward if we somehow also roll out Che nightlies. I think that after all deployment methods are updated to deploy registries alongside Che, we should leave the |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use https://che-plugin-registry.prod-preview.openshift.io and https://che-devfile-registry.prod-preview.openshift.io/ instead of their production equivalents.
What issues does this PR fix or reference?
#14266, #14261