Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the chances that successfulCheckTest will fail #14688

Merged
merged 5 commits into from
Sep 30, 2019

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

The cause of the fail is that TestServerChecker has only 500msec to do the job correctly in successfulCheckTest. Since successfulCheckTest is the single testcase that used TestServerChecker constructed in setUp it may occasionally fail if the time between setUp and successfulCheckTest.checker.start(); are longer then 500msec

What issues does this PR fix or reference?

#13211

Release Notes

n/a

Docs PR

n/a

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 27, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14688

@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14688

@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14688

@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14688

@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 28, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14688

@che-bot
Copy link
Contributor

che-bot commented Sep 28, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@skabashnyuk
Copy link
Contributor Author

@eclipse/eclipse-che-qa can you review test results?

@dmytro-ndp
Copy link
Contributor

@skabashnyuk: there is expected failure in Java selenium tests results here. No regression is found.

@skabashnyuk skabashnyuk merged commit 66d7729 into master Sep 30, 2019
@skabashnyuk skabashnyuk deleted the fixupServerCheckerTest branch September 30, 2019 06:52
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 30, 2019
@che-bot che-bot added this to the 7.3.0 milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants