Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent workspace restarting if user intentionally stopped it #14728

Merged
merged 2 commits into from
Oct 9, 2019
Merged

prevent workspace restarting if user intentionally stopped it #14728

merged 2 commits into from
Oct 9, 2019

Conversation

akurinnoy
Copy link
Contributor

Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com

What does this PR do?

Fix bug when user cannot interrupt a workspace start.

What issues does this PR fix or reference?

fixes #14567

@akurinnoy akurinnoy self-assigned this Oct 1, 2019
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Oct 1, 2019
@che-bot
Copy link
Contributor

che-bot commented Oct 1, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14728

@che-bot
Copy link
Contributor

che-bot commented Oct 1, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

vitaliy-guliy
vitaliy-guliy reviewed Oct 7, 2019
View reviewed changes
workspace-loader/src/workspace-loader.ts Outdated
@@ -26,6 +26,10 @@ export class WorkspaceLoader {
private workspace: che.workspace.Workspace;
private runtimeIsAccessible: Deferred<void>;

// `false` if workspace has been stopped intentionally
// and workspace-loader should not restart it
private doRestart: boolean = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. Restart means the sequence of actions: stop and then start. Is this variable indeed means that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the best name, indeed. I suppose that allowRestart makes more sense, doesn't it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let it be allowRestart

@akurinnoy akurinnoy force-pushed the workspace-loader-fix-stopping branch from e9ef6d3 to 9c677ed Compare October 8, 2019 09:07
@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@dmytro-ndp
Copy link
Contributor

ci-build

@dmytro-ndp
Copy link
Contributor

ci-test

@dmytro-ndp
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@akurinnoy
Copy link
Contributor Author

ci-build

@akurinnoy
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@dmytro-ndp
Copy link
Contributor

@akurinnoy: there is expected regression in Java selenium tests. It was fixed yesterday 720aab0.

@akurinnoy akurinnoy merged commit 87a0ad3 into master Oct 9, 2019
@akurinnoy akurinnoy deleted the workspace-loader-fix-stopping branch October 9, 2019 08:18
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 9, 2019
@che-bot che-bot added this to the 7.3.0 milestone Oct 9, 2019
skabashnyuk pushed a commit to skabashnyuk/che that referenced this pull request Mar 11, 2020
@akurinnoy
prevent workspace restarting if user intentionally stopped it (eclips…
d7a50ea 
…e-che#14728)

* prevent workspace restarting if user intentionally stopped it

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! prevent workspace restarting if user intentionally stopped it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorhun mmorhun mmorhun approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@olexii4 olexii4 olexii4 approved these changes

@vitaliy-guliy vitaliy-guliy vitaliy-guliy approved these changes

@evidolob evidolob evidolob approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@akurinnoy akurinnoy

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

Workspace is continuously restarted after start interruption
8 participants
@akurinnoy @che-bot @dmytro-ndp @evidolob @vitaliy-guliy @olexii4 @AndrienkoAleksandr @mmorhun