Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load devfile schema for validation by it's apiVersion #14834

Merged
merged 4 commits into from
Oct 11, 2019
Merged

load devfile schema for validation by it's apiVersion #14834

merged 4 commits into from
Oct 11, 2019

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Oct 9, 2019

What does this PR do?

Make it possible to have multiple devfile schemas for validation. The schema is now placed in directory named by version and supported versions are listed in .devfile.Constants#SUPPORTED_VERSIONS

What issues does this PR fix or reference?

#14824

@sparkoo sparkoo changed the title load devfile schemas by version load devfile schema for validation by it's apiVersion Oct 9, 2019
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Oct 9, 2019
@che-bot
Copy link
Contributor

che-bot commented Oct 9, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 10, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 10, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 10, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 10, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 10, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

Copy link
Contributor

@mshaposhnik mshaposhnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general OK for me (with some minor comments).

Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Oct 11, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 11, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@che-bot
Copy link
Contributor

che-bot commented Oct 11, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@dmytro-ndp
Copy link
Contributor

@sparkoo: there is known regression in Happy path tests result: #14862.

Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the trivial error message formatting nitpicks. Feel free to ignore them if you don't agree. I like the simplicity of the solution. At the same time we can build on this in the future. Good job!

@sparkoo sparkoo merged commit ae2500f into eclipse-che:master Oct 11, 2019
@sparkoo sparkoo deleted the devfileValidation branch October 11, 2019 15:52
@che-bot che-bot added this to the 7.3.0 milestone Oct 11, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants