-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load devfile schema for validation by it's apiVersion #14834
Conversation
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
...main/java/org/eclipse/che/api/workspace/server/devfile/validator/DevfileSchemaValidator.java
Outdated
Show resolved
Hide resolved
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general OK for me (with some minor comments).
...src/main/java/org/eclipse/che/api/workspace/server/devfile/schema/DevfileSchemaProvider.java
Outdated
Show resolved
Hide resolved
wsmaster/che-core-api-workspace/src/main/resources/schema/1.0.0/devfile.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
@sparkoo: there is known regression in Happy path tests result: #14862. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the trivial error message formatting nitpicks. Feel free to ignore them if you don't agree. I like the simplicity of the solution. At the same time we can build on this in the future. Good job!
What does this PR do?
Make it possible to have multiple devfile schemas for validation. The schema is now placed in directory named by version and supported versions are listed in
.devfile.Constants#SUPPORTED_VERSIONS
What issues does this PR fix or reference?
#14824