CHE-3844: Show 'Add terminal button' in the machine nodes when Workspace is running #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrienkoAleksandr
requested review from
azatsarynnyy,
vparfonov and
RomanNikitenko
azatsarynnyy
approved these changes
Mar 29, 2017
RomanNikitenko
approved these changes
Mar 29, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2314/ |
vparfonov
approved these changes
Apr 3, 2017
…ace is running. Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
AndrienkoAleksandr
force-pushed
the
CHE-3844
branch
from
4324967 to
b623d6f
Compare
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…ace is running. (eclipse-che#4618) Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Show 'Add terminal button' in the machine nodes when workspace is running. Earlier We shown this button when machine had got status "running", but on this phase start IDE terminal agent was not installed yet on the machine.
What issues does this PR fix or reference?
#3844
Changelog
Show 'Add terminal button' in the machine nodes when Workspace is running
Release Notes
Show 'Add terminal button' in the machine nodes when Workspace is running
Docs PR
Not needed, this is bug fix.
Signed-off-by: Aleksandr Andrienko aandrienko@codenvy.com