-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize containsAll on RichIterable. #1344 #1353
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -297,15 +297,23 @@ else if (inside.size() > 32 && !(inside instanceof SetIterable)) | |
* | ||
* @since 1.0 | ||
*/ | ||
boolean containsAllIterable(Iterable<?> source); | ||
default boolean containsAllIterable(Iterable<?> source) | ||
{ | ||
RichIterable<?> outside = this.toSet(); | ||
return StreamSupport.stream(source.spliterator(), false).allMatch(outside::contains); | ||
} | ||
|
||
/** | ||
* Returns true if all elements in source are contained in this collection. | ||
* | ||
* @see Collection#containsAll(Collection) | ||
* @since 1.0 | ||
*/ | ||
boolean containsAll(Collection<?> source); | ||
default boolean containsAll(Collection<?> source) | ||
{ | ||
return source instanceof RichIterable ? this.containsAllIterable(source) | ||
: source.stream().allMatch(this::contains); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't understand the conditional here. What does it matter if In addition, containsAllIterable() may convert |
||
|
||
/** | ||
* Returns true if all elements in the specified var arg array are contained in this collection. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a set, then calling toSet() is unnecessary, and this implementation is slower than necessary. I think we should leave this abstract on RichIterable.