Fixes #1717 - overflow issues in LongInterval #1718
Merged
+173
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donraab
requested changes
Oct 15, 2024
| public void forEachWithIndexForLargeValues() | ||
| { | ||
| var values1 = LongLists.mutable.empty(); | ||
| var indices1 = LongLists.mutable.empty(); |
There was a problem hiding this comment.
It would be clearer if the indices1 were a MutableIntList.
There is also another method you changed named forEachWithLongIndex which would make perfect sense for this test.
There was a problem hiding this comment.
forEachWithLongIndex is not used and deprecated for removal (that was the change 😀) so I would rather not used it. Will change indices to MutableIntList.
donraab
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.