Gradle Project hasn't been updated properly #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testforstephen
requested changes
Nov 30, 2020
org.eclipse.jdt.ls.tests/projects/gradle/sample/app/build.gradle
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleBuildSupport.java
Outdated
Show resolved
Hide resolved
|
@testforstephen I have updated the PR. |
rgrunber
reviewed
Dec 1, 2020
Fixed. |
|
Updated change also works for me. Gradle project is detected and libraries are available as defined by the build file. |
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/BasicFileDetector.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleBuildSupport.java
Show resolved
Hide resolved
- redhat-developer/vscode-java#1714 - redhat-developer/vscode-java#1463 Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
@testforstephen I have updated the PR. |
testforstephen
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#1714
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com