Fixes Self-loop label bug when using compaction #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self-loop labels were previously omitted during compaction. This PR moves them together with everything else.
soerendomroes
approved these changes
Oct 22, 2024
I looked into the current tests for compaction and they are only algorithmic tests on the CGraph i.e. not on the underlying graph elements. It would probably be good to add such a test to check that compaction has been properly applied to all elements of the graph. This would help avoid bugs such as this in the future, but I'm not sure what the best approach for that would be. Maybe we could merge this fix now, and open an issue to add better compaction tests in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-loop labels were previously omitted during compaction. This PR moves them together with everything else.