:fix: service events remove durable subscriptions #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardomodanese
force-pushed
the
fix-service_events_remove_durable_subs
branch
from
144bc00
to
9936a0f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4023 +/- ##
==========================================
Coverage 16.67% 16.67%
Complexity 22 22
==========================================
Files 2009 2009
Lines 52223 52223
Branches 4437 4437
==========================================
Hits 8706 8706
Misses 43113 43113
Partials 404 404
|
riccardomodanese
force-pushed
the
fix-service_events_remove_durable_subs
branch
2 times, most recently
from
9639600
to
7f52653
Compare
Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
riccardomodanese
force-pushed
the
fix-service_events_remove_durable_subs
branch
from
7f52653
to
6d7c6d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR.
switch from durable to "normal" subscriptions for events.
In this way, if a container is removed, we prevent message leak and event broker crash
Related Issue
none
Description of the solution adopted
See Brief description
Screenshots
none
Any side note on the changes made
none