fix: test result shown as failed when a subtest fails #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 95.41% 95.41%
=======================================
Files 72 72
Lines 5584 5589 +5
=======================================
+ Hits 5328 5333 +5
Misses 256 256
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sebclrsn
reviewed
Jan 20, 2023
| :param err: tuple returned by sys.exc_info | ||
| """ | ||
| super().addSubTest(test, subtest, err) | ||
| if err is not None: |
There was a problem hiding this comment.
Best way of doing it! :)
sebclrsn
approved these changes
Jan 20, 2023
sebastianpfischer
approved these changes
Jan 20, 2023
Pog3k
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that the test is shown as passed when a subtest failed.