Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property location and jump to location in mouse over popup #370 #374

Conversation

vrubezhny
Copy link
Contributor

@vrubezhny vrubezhny commented Mar 2, 2023

The location link is added to the hover:

Screenshot from 2023-03-02 19-53-46

@vrubezhny vrubezhny linked an issue Mar 2, 2023 that may be closed by this pull request
@vrubezhny vrubezhny force-pushed the fixMavenPropertyHover-addLocationLink branch from d996f87 to 7e96b48 Compare March 2, 2023 21:27
@vrubezhny vrubezhny force-pushed the fixMavenPropertyHover-addLocationLink branch from 7e96b48 to 14c0259 Compare March 3, 2023 04:16
@mickaelistria mickaelistria merged commit 9278c6e into eclipse:master Mar 3, 2023
@mickaelistria
Copy link
Contributor

Thank you!

@Kiiv
Copy link

Kiiv commented Mar 3, 2023

So great! Thanks, I miss this so much 🙂

@angelozerr
Copy link
Contributor

@vrubezhny I forget to say you that you need to use System.lineSeparator when you write markdown instead of hard coding with\n because If I remember it will not work on Windows os on vscode

@vrubezhny
Copy link
Contributor Author

@vrubezhny I forget to say you that you need to use System.lineSeparator when you write markdown instead of hard coding with\n because If I remember it will not work on Windows os on vscode

I'll add a PR to fix this.

@mickaelistria @angelozerr What do you think of "double" line break in hover between the rows? (The line spaces seen in the screenshot are made by double newline chars (\n \n) - do we really need this extra space in hover?

@angelozerr
Copy link
Contributor

I'll add a PR to fix this.

Thanks, and please use System.lineSeparator in the extected result of test. It will work for you and for CI build if you use \n but not for Windows OS

@mickaelistria
Copy link
Contributor

I don't really care at the moment about it. I'd like to see how this looks in actual hover to take a decision here.

@vrubezhny
Copy link
Contributor Author

@mickaelistria Well. It was probably a stupid question... It looks like markdown needs that "double" new line to really add a line break. With having only one new line char the hover looks like the following (everything is placed in one line):
Screenshot from 2023-03-03 14-40-06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property location and jump to location in mouse over popup
4 participants