Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maven-resolver.version from 1.9.12 to 1.9.13 in /lemminx-maven #422

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 23, 2023

Bumps maven-resolver.version from 1.9.12 to 1.9.13.
Updates maven-resolver-api from 1.9.12 to 1.9.13

Release notes

Sourced from maven-resolver-api's releases.

Maven Resolver 1.9.13

Release notes in JIRA: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353352

Release Notes - Maven Resolver - Version 1.9.13


What's Changed

Full Changelog: apache/maven-resolver@maven-resolver-1.9.12...maven-resolver-1.9.13

Commits
  • e5556b5 [maven-release-plugin] prepare release maven-resolver-1.9.13
  • 30e1cb6 Extend NamedLocks doco (#304)
  • 4fb1cf9 [MRESOLVER-373] Make GavNameResolver to distinguish names better (#303)
  • 1acec9b [MRESOLVER-373] Partially undo MRESOLVER-346 (#302)
  • 7395cd4 [MRESOLVER-220] Refuse proactively unsupported operation (#301)
  • 2e108aa [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Updates maven-resolver-spi from 1.9.12 to 1.9.13

Release notes

Sourced from maven-resolver-spi's releases.

Maven Resolver 1.9.13

Release notes in JIRA: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353352

Release Notes - Maven Resolver - Version 1.9.13


What's Changed

Full Changelog: apache/maven-resolver@maven-resolver-1.9.12...maven-resolver-1.9.13

Commits
  • e5556b5 [maven-release-plugin] prepare release maven-resolver-1.9.13
  • 30e1cb6 Extend NamedLocks doco (#304)
  • 4fb1cf9 [MRESOLVER-373] Make GavNameResolver to distinguish names better (#303)
  • 1acec9b [MRESOLVER-373] Partially undo MRESOLVER-346 (#302)
  • 7395cd4 [MRESOLVER-220] Refuse proactively unsupported operation (#301)
  • 2e108aa [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Updates maven-resolver-util from 1.9.12 to 1.9.13

Release notes

Sourced from maven-resolver-util's releases.

Maven Resolver 1.9.13

Release notes in JIRA: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353352

Release Notes - Maven Resolver - Version 1.9.13


What's Changed

Full Changelog: apache/maven-resolver@maven-resolver-1.9.12...maven-resolver-1.9.13

Commits
  • e5556b5 [maven-release-plugin] prepare release maven-resolver-1.9.13
  • 30e1cb6 Extend NamedLocks doco (#304)
  • 4fb1cf9 [MRESOLVER-373] Make GavNameResolver to distinguish names better (#303)
  • 1acec9b [MRESOLVER-373] Partially undo MRESOLVER-346 (#302)
  • 7395cd4 [MRESOLVER-220] Refuse proactively unsupported operation (#301)
  • 2e108aa [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Updates maven-resolver-impl from 1.9.12 to 1.9.13

Release notes

Sourced from maven-resolver-impl's releases.

Maven Resolver 1.9.13

Release notes in JIRA: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353352

Release Notes - Maven Resolver - Version 1.9.13


What's Changed

Full Changelog: apache/maven-resolver@maven-resolver-1.9.12...maven-resolver-1.9.13

Commits
  • e5556b5 [maven-release-plugin] prepare release maven-resolver-1.9.13
  • 30e1cb6 Extend NamedLocks doco (#304)
  • 4fb1cf9 [MRESOLVER-373] Make GavNameResolver to distinguish names better (#303)
  • 1acec9b [MRESOLVER-373] Partially undo MRESOLVER-346 (#302)
  • 7395cd4 [MRESOLVER-220] Refuse proactively unsupported operation (#301)
  • 2e108aa [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 23, 2023
@vrubezhny
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/lemminx-maven/maven-resolver.version-1.9.13 branch from 178aaf6 to 40e97b6 Compare June 23, 2023 14:04
@vrubezhny vrubezhny marked this pull request as draft June 23, 2023 18:13
@vrubezhny
Copy link
Contributor

vrubezhny commented Jun 23, 2023

More than 70% of attempts to build a Maven Project Snapshot end up with the following exceptions written to the log:

Jun 23, 2023 2:23:02 PM org.eclipse.lemminx.extensions.maven.MavenProjectCache parseAndCache
SEVERE: Could not acquire lock(s)
java.lang.IllegalStateException: Could not acquire lock(s)
	at org.eclipse.aether.internal.impl.synccontext.named.NamedLockFactoryAdapter$AdaptedLockSyncContext.acquire(NamedLockFactoryAdapter.java:219)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:271)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:259)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:242)
	at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:231)
	at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:172)
	at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.resolveCachedArtifactDescriptor(DfDependencyCollector.java:382)
	at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.getArtifactDescriptorResult(DfDependencyCollector.java:368)
	at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency(DfDependencyCollector.java:218)
	at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency(DfDependencyCollector.java:156)
	at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.process(DfDependencyCollector.java:138)
	at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doCollectDependencies(DfDependencyCollector.java:108)
	at org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:222)
	at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
	at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:305)
	at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
	at org.apache.maven.project.DefaultProjectBuilder.resolveDependencies(DefaultProjectBuilder.java:224)
	at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:202)
	at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:139)
	at org.eclipse.lemminx.extensions.maven.MavenProjectCache.parseAndCache(MavenProjectCache.java:159)
	at org.eclipse.lemminx.extensions.maven.MavenProjectCache.parseAndCache(MavenProjectCache.java:240)
	at org.eclipse.lemminx.extensions.maven.MavenProjectCache.check(MavenProjectCache.java:130)
	at org.eclipse.lemminx.extensions.maven.MavenProjectCache.getLastSuccessfulMavenProject(MavenProjectCache.java:105)
	at org.eclipse.lemminx.extensions.maven.MavenLemminxWorkspaceReader$ResolveArtifactsAndPopulateWorkspaceRunnable.run(MavenLemminxWorkspaceReader.java:79)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
	Suppressed: java.lang.IllegalStateException: Attempt 1: Could not acquire write lock for 'artifact:org.test.modules:ModuleA:0.0.1-SNAPSHOT' in 30 SECONDS
		at org.eclipse.aether.internal.impl.synccontext.named.NamedLockFactoryAdapter$AdaptedLockSyncContext.acquire(NamedLockFactoryAdapter.java:202)
		... 26 more
	Suppressed: java.lang.IllegalStateException: Attempt 2: Could not acquire write lock for 'artifact:org.test.modules:ModuleA:0.0.1-SNAPSHOT' in 30 SECONDS
		at org.eclipse.aether.internal.impl.synccontext.named.NamedLockFactoryAdapter$AdaptedLockSyncContext.acquire(NamedLockFactoryAdapter.java:202)
		... 26 more

Every such failing attempt to acquire a lock takes ~60 seconds to finish (fail) - while normally a test Maven Project (from Lemminx-Maven JUnit tests) takes 5-50 ms to resolve.

So building and running JUnit tests with maven-resolver v.1.9.13 took 3h 16m while it normally takes about 7m 30s to finish.

@vrubezhny
Copy link
Contributor

I have reported the maven resolver v.1.9.13 to JIRA - https://issues.apache.org/jira/browse/MRESOLVER-374

@dependabot dependabot bot force-pushed the dependabot/maven/lemminx-maven/maven-resolver.version-1.9.13 branch from 40e97b6 to 69199fd Compare June 27, 2023 00:28
@vrubezhny
Copy link
Contributor

The functionality should be fixed with #426

@vrubezhny vrubezhny marked this pull request as ready for review June 27, 2023 01:22
@vrubezhny
Copy link
Contributor

@dependabot rebase

Bumps `maven-resolver.version` from 1.9.12 to 1.9.13.

Updates `maven-resolver-api` from 1.9.12 to 1.9.13
- [Release notes](https://github.com/apache/maven-resolver/releases)
- [Commits](apache/maven-resolver@maven-resolver-1.9.12...maven-resolver-1.9.13)

Updates `maven-resolver-spi` from 1.9.12 to 1.9.13
- [Release notes](https://github.com/apache/maven-resolver/releases)
- [Commits](apache/maven-resolver@maven-resolver-1.9.12...maven-resolver-1.9.13)

Updates `maven-resolver-util` from 1.9.12 to 1.9.13
- [Release notes](https://github.com/apache/maven-resolver/releases)
- [Commits](apache/maven-resolver@maven-resolver-1.9.12...maven-resolver-1.9.13)

Updates `maven-resolver-impl` from 1.9.12 to 1.9.13
- [Release notes](https://github.com/apache/maven-resolver/releases)
- [Commits](apache/maven-resolver@maven-resolver-1.9.12...maven-resolver-1.9.13)

---
updated-dependencies:
- dependency-name: org.apache.maven.resolver:maven-resolver-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven.resolver:maven-resolver-spi
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven.resolver:maven-resolver-util
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven.resolver:maven-resolver-impl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/lemminx-maven/maven-resolver.version-1.9.13 branch from 69199fd to 4563240 Compare June 27, 2023 01:23
@vrubezhny vrubezhny merged commit a5af6b7 into master Jun 27, 2023
@dependabot dependabot bot deleted the dependabot/maven/lemminx-maven/maven-resolver.version-1.9.13 branch June 27, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant