Maven project cache cannot be done if one of pom.xml of the workspace doesn't define artifact id. #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
artifact-no-validation2
branch
3 times, most recently
from
275f450
to
5bd73be
Compare
doesn't define artifact id. Signed-off-by: azerr <azerr@redhat.com>
angelozerr
force-pushed
the
artifact-no-validation2
branch
from
5bd73be
to
cb57c3c
Compare
vrubezhny
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven project cache cannot be done if one of pom.xml of the workspace
doesn't define artifact id.
If there is one pom.xml in the workspace which doesn't define an artifactid, a version or a groupdid, the call of ArtifactUtils.key and ArtifactUtils.versionLessKey throws an exception and breaks the all code.
For instance it breaks the cache of some pom.xml if ArtifactUtils.key is called with an artifcat which have no group id.