Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove diagnostic for managed bean public field with invalid scope #535

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

turkeylurkey
Copy link
Contributor

We clarified this rule with the Liberty CDI team and decided the latest added diagnostic is not correct. The fix for the original diagnostic is correct. The issue #534 has a bit more explanation.

https://jakarta.ee/specifications/cdi/3.0/jakarta-cdi-spec-3.0.html#managed_beans

Fixes #534

Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Copy link
Contributor

@mezarin mezarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turkeylurkey turkeylurkey merged commit 10887f9 into eclipse:main Nov 8, 2024
2 checks passed
@turkeylurkey turkeylurkey deleted the issue-534 branch November 8, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid diagnostic on a field in a managed bean
2 participants