Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a quick fix that removes both annotations when the two are mutually exclusive #539

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

turkeylurkey
Copy link
Contributor

Pull request #511 added a quick fix which removes all three annotations from a parameter when some of the annotations are in conflict. E.g. "@Disposes @observes @ObservesAsync String name" There should be two quick fixes, one that removes @Disposes and one that removes @observes and @ObservesAsync.

In this pull request we temporarily remove the quick fix from two situations along with the tests that validate them. There is an issue open to fix the code so we can restore the quick fix.

…ually exclusive

Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey turkeylurkey added the bug Something isn't working label Nov 14, 2024
@turkeylurkey turkeylurkey changed the title Remove two quick fixes that remove both annotations when they are mutually exclusive Remove a quick fix that removes both annotations when the two are mutually exclusive Nov 14, 2024
@turkeylurkey turkeylurkey merged commit 53d7e0c into eclipse:main Nov 15, 2024
2 checks passed
@turkeylurkey turkeylurkey deleted the fixPR511 branch November 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants