Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CodeAction performance with CodeAction#data & resolveCodeAction #171

Closed
angelozerr opened this issue Aug 27, 2021 · 0 comments · Fixed by #299
Closed

Improve CodeAction performance with CodeAction#data & resolveCodeAction #171

angelozerr opened this issue Aug 27, 2021 · 0 comments · Fixed by #299
Assignees
@datho7561
Labels
code action
Milestone
0.6.0

Comments

@angelozerr
Copy link
Contributor

See my lemMinx comments eclipse-lemminx/lemminx#941 (comment)
datho7561 added a commit to datho7561/vscode-microprofile that referenced this issue Oct 5, 2022
@datho7561
Provide bindings for CodeAction stubs and CodeAction resolve
ff27afc 
See eclipse/lsp4mp#171

Signed-off-by: David Thompson <davthomp@redhat.com>
This was referenced Oct 5, 2022
Closed
Merged
Merged
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Oct 14, 2022
@datho7561
Support CodeAction resolve for Java code actions
bf9c0da 
Resolve workspace edits only when the code action is applied
for all code actions for Java files that modify source files.
This should increase the performance of editing Java files with lsp4mp
active, since the edits of all the code actions don't need to be
computed.

I also adjusted the title of the "Add @operation annotation" code action
to include the class that the code action will apply to.

Closes eclipse#171

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Oct 14, 2022
@datho7561
Support CodeAction resolve for Java code actions
1605fbe 
Resolve workspace edits only when the code action is applied
for all code actions for Java files that modify source files.
This should increase the performance of editing Java files with lsp4mp
active, since the edits of all the code actions don't need to be
computed.

I also adjusted the title of the "Add @operation annotation" code action
to include the class that the code action will apply to.

Closes eclipse#171

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Oct 14, 2022
@datho7561
Support CodeAction resolve for Java code actions
3e60ef1 
Resolve workspace edits only when the code action is applied
for all code actions for Java files that modify source files.
This should increase the performance of editing Java files with lsp4mp
active, since the edits of all the code actions don't need to be
computed.

I also adjusted the title of the "Add @operation annotation" code action
to include the class that the code action will apply to.

Closes eclipse#171

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-microprofile that referenced this issue Oct 17, 2022
@datho7561
Provide binding for CodeAction resolve
492d92d 
See eclipse/lsp4mp#171

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 19, 2022
@datho7561 @angelozerr
Support CodeAction resolve for Java code actions
f5571c3 
Resolve workspace edits only when the code action is applied
for all code actions for Java files that modify source files.
This should increase the performance of editing Java files with lsp4mp
active, since the edits of all the code actions don't need to be
computed.

I also adjusted the title of the "Add @operation annotation" code action
to include the class that the code action will apply to.

Closes #171

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 0.6.0 milestone Oct 19, 2022
angelozerr pushed a commit to redhat-developer/vscode-microprofile that referenced this issue Oct 19, 2022
@datho7561 @angelozerr
Provide binding for CodeAction resolve
9f45647 
See eclipse/lsp4mp#171

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
code action
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Support CodeAction resolve for Java code actions datho7561/lsp4mp
2 participants
@angelozerr @datho7561