633 - fix backslack comma behaviour #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emily-Jiang
force-pushed
the
633-backslash-comma
branch
from
23a97f6
to
8f817bf
Compare
Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
Emily-Jiang
force-pushed
the
633-backslash-comma
branch
from
b6469cb
to
fa74614
Compare
|
@radcortez @jbee please review |
jbee
approved these changes
Oct 30, 2020
...n/java/org/eclipse/microprofile/config/tck/emptyvalue/EmptyValuesTestProgrammaticLookup.java
Outdated
Show resolved
Hide resolved
radcortez
approved these changes
Oct 30, 2020
…ue/EmptyValuesTestProgrammaticLookup.java Co-authored-by: Jan Bernitt <jaanbernitt@gmail.com>
There was an entry on the release note: spec/src/main/asciidoc/release_notes.asciidoc |
|
I think I've messed up when I tried this PR and didn't notice that we need to remove this piece: This is testing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #633
Signed-off-by: Emily Jiang emijiang6@googlemail.com