Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update osgi.annotation dependency to 8.1.0 #732

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

bjhargrave
Copy link
Member

Version 8.1.0 removes the use of enum types in the annotations which
avoids compiler warnings for downstream users of the api jar.

We also include osgi.annotation in the tck project to make the
annotation classes available to javadoc to avoid warnings.

Version 8.1.0 removes the use of enum types in the annotations which
avoids compiler warnings for downstream users of the api jar.

We also include osgi.annotation in the tck project to make the
annotation classes available to javadoc to avoid warnings.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
@bjhargrave
Copy link
Member Author

@Emily-Jiang This addresses the compiler warning issue in #716.

@radcortez radcortez linked an issue Feb 11, 2022 that may be closed by this pull request
@radcortez
Copy link
Contributor

Great. Thank you!

@radcortez radcortez merged commit 18d1b92 into eclipse:master Feb 11, 2022
@radcortez
Copy link
Contributor

I believe this should be backported to 2.x.

@bjhargrave
Copy link
Member Author

I believe this should be backported to 2.x.

I can make a PR for that. What branch?

@bjhargrave bjhargrave deleted the osgi.annotation-8.1.0 branch February 11, 2022 13:34
@radcortez
Copy link
Contributor

I believe this should be backported to 2.x.

I can make a PR for that. What branch?

We don't have one. Let me create one. Thanks!

@radcortez
Copy link
Contributor

@Emily-Jiang
Copy link
Member

Thank you @bjhargrave !

@Emily-Jiang
Copy link
Member

@radcortez we can do a service release once @bjhargrave makes a PR against 2.x.

@brunolmfg
Copy link

Unfortunately that fix was merged into master after the 3.0.x was branched. So the version 3.0.2 doesn't contain the upgrade of osgi.annotation to 8.1.0.

Looking in the history I've notice some confusing versioning:

@radcortez, @bjhargrave and @Emily-Jiang I believe this should be backported to 3.0.x.

@turing85 It seems to me that the problem you posted on Quarkus Zulip is due to the upgrade of MP Config from 2.0.1 (osgi.annotation fixed) to 3.0 (osgi.annotation not fixed) present in Quarkus 3.0.0.Alpha1 and later.

@radcortez
Copy link
Contributor

We need to do a release to fix other stuff, so we might as well just release it as is and let consumers update to the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OSGi annotations from the API
4 participants