Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worth saying that checks are unordered? #106

Closed
scottkurz opened this issue Sep 18, 2017 · 8 comments · Fixed by #151
Closed

Worth saying that checks are unordered? #106

scottkurz opened this issue Sep 18, 2017 · 8 comments · Fixed by #151
Assignees
Milestone

Comments

@scottkurz
Copy link
Contributor

Relatively new to this, so not sure if this has come up before....

Thinking it might be worth saying that the checks are unordered (assuming I haven't missed some discussion where there was supposed to be an order; relatively new to the discussion here).

Given that probably a given implementation will return the same types of checks in the same order, I could imagine if I try hard enough someone building some dependency on the order of checks.

A specific statement that you shouldn't would make this clear.

@heiko-braun
Copy link
Contributor

+1

@heiko-braun heiko-braun added this to the 1.1 milestone Sep 20, 2017
@heiko-braun
Copy link
Contributor

I think this will be superseded by #110 . @scottkurz Thoughts?

@scottkurz
Copy link
Contributor Author

Agree that if we were to proceed with the proposal in #110 then this issue #106 would become obsolete.

But I don't see that #110 has progressed any since, as noted there, the proposals there seem to either incompatible with the existing format or potentially implementation-specific.

But maybe that's just repeating the obvious... are you asking what I think about #106?

@johnament
Copy link
Contributor

Can checks perhaps be ordered by adding @Priority somewhere? Or perhaps is it OK if checks are actually executed in other threads?

@scottkurz
Copy link
Contributor Author

Well, I was just opening this to more clearly articulate (in the spec wording) the decision that I assumed had been made. So any other ideas are really separate from my angle here.

@heiko-braun
Copy link
Contributor

heiko-braun commented Nov 22, 2017

As @scottkurz said, the initial motivation behind this issues was to clearly point out that checks are not ordered. And I still don't see why they should be. There is a single overall outcome and the order of execution doesn't change anything, does it?

@cescoffier
Copy link
Contributor

I believe it should be written in the spec, just to be clear.

@antoinesd
Copy link
Contributor

We agree to add this statement

@antoinesd antoinesd self-assigned this Oct 12, 2018
antoinesd added a commit to antoinesd/microprofile-health that referenced this issue Nov 29, 2018
fixes eclipse#106

Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants