Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a TCK test for RSA keys of 1024 bit key length #194

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Add a TCK test for RSA keys of 1024 bit key length #194

merged 1 commit into from
Jul 7, 2020

Conversation

sberyozkin
Copy link
Contributor

@sberyozkin sberyozkin commented Jul 2, 2020 •
edited
Loading

Fixes #197

A simple test has been added to verify that a token signed with the 1024 bit length RSA key is accepted, it reuses the RolesAllowed endpoint

CC @darranl, @teddyjtorres

@sberyozkin sberyozkin added this to the JWT-1.2 milestone Jul 2, 2020
@sberyozkin sberyozkin force-pushed the rsa1024BitLength branch 4 times, most recently from 6954f71 to 8fc8fa3 Compare July 3, 2020 20:16
@sberyozkin
Copy link
Contributor Author

Hi All, I've updated this PR to fix the issue introduced with the migration to Jose4j - which is directly related to the RSA 1024 bit length. Jose4j enforces 2048+ length by default - which was not the case with nimbus-jwt. So TokenUtils.sign(...) now allows 1024 OOB.

@sberyozkin
Copy link
Contributor Author

TCK has been verified

@sberyozkin
Copy link
Contributor Author

@rdebusscher Hi Rudy, this is a simple PR so I'd like to go ahead asap to complete the 1.2 work, but I'll wait until tomorrow for you to provide the feedback. As always, please create a new issue if you'll get concerned with something about this PR in particular

@sberyozkin sberyozkin merged commit 4b50227 into eclipse:master Jul 7, 2020
@sberyozkin sberyozkin deleted the rsa1024BitLength branch July 8, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcortez radcortez radcortez approved these changes

@rdebusscher rdebusscher Awaiting requested review from rdebusscher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MPJWT-1.2
Development

Successfully merging this pull request may close these issues.

Add TCK test which confirms that JWTs signed with RSA keys of 1024 bit length are verified
2 participants
@sberyozkin @radcortez